third_party/WebKit/Source/core/css/resolver/ElementStyleResources.h - Issue 1387113002: Change StyleResolverState.styleImage() to take a const CSSValue&

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/css/resolver/ElementStyleResources.h

Issue 1387113002: Change StyleResolverState.styleImage() to take a const CSSValue& (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Added TODOs to replace the members with const members Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/css/resolver/CSSToStyleMap.cpp ('k') | third_party/WebKit/Source/core/css/resolver/ElementStyleResources.cpp » ('j') | third_party/WebKit/Source/core/style/StylePendingImage.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/css/resolver/ElementStyleResources.h

diff --git a/third_party/WebKit/Source/core/css/resolver/ElementStyleResources.h b/third_party/WebKit/Source/core/css/resolver/ElementStyleResources.h

index 61c1eae151c05adc88df3a9115c8606e61b1b3b1..16fc359ef5abbb93cf4f71010b33691fcca56513 100644

--- a/third_party/WebKit/Source/core/css/resolver/ElementStyleResources.h

+++ b/third_party/WebKit/Source/core/css/resolver/ElementStyleResources.h

@@ -52,12 +52,12 @@ class ElementStyleResources {

public:

ElementStyleResources();

- PassRefPtrWillBeRawPtr<StyleImage> styleImage(Document&, CSSPropertyID, CSSValue*);

+ PassRefPtrWillBeRawPtr<StyleImage> styleImage(Document&, CSSPropertyID, const CSSValue&);

- PassRefPtrWillBeRawPtr<StyleImage> generatedOrPendingFromValue(CSSPropertyID, CSSImageGeneratorValue*);

- PassRefPtrWillBeRawPtr<StyleImage> cachedOrPendingFromValue(Document&, CSSPropertyID, CSSImageValue*);

- PassRefPtrWillBeRawPtr<StyleImage> setOrPendingFromValue(CSSPropertyID, CSSImageSetValue*);

- PassRefPtrWillBeRawPtr<StyleImage> cursorOrPendingFromValue(CSSPropertyID, CSSCursorImageValue*);

+ PassRefPtrWillBeRawPtr<StyleImage> generatedOrPendingFromValue(CSSPropertyID, const CSSImageGeneratorValue&);

+ PassRefPtrWillBeRawPtr<StyleImage> cachedOrPendingFromValue(Document&, CSSPropertyID, const CSSImageValue&);

+ PassRefPtrWillBeRawPtr<StyleImage> setOrPendingFromValue(CSSPropertyID, const CSSImageSetValue&);

+ PassRefPtrWillBeRawPtr<StyleImage> cursorOrPendingFromValue(CSSPropertyID, const CSSCursorImageValue&);

const PendingImagePropertySet& pendingImageProperties() const { return m_pendingImageProperties; }

const PendingSVGDocumentMap& pendingSVGDocuments() const { return m_pendingSVGDocuments; }