third_party/WebKit/Source/core/css/resolver/CSSToStyleMap.cpp - Issue 1387113002: Change StyleResolverState.styleImage() to take a const CSSValue&

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/css/resolver/CSSToStyleMap.cpp

Issue 1387113002: Change StyleResolverState.styleImage() to take a const CSSValue& (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Added TODOs to replace the members with const members Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/css/resolver/AnimatedStyleBuilder.cpp ('k') | third_party/WebKit/Source/core/css/resolver/ElementStyleResources.h » ('j') | third_party/WebKit/Source/core/style/StylePendingImage.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/css/resolver/CSSToStyleMap.cpp

diff --git a/third_party/WebKit/Source/core/css/resolver/CSSToStyleMap.cpp b/third_party/WebKit/Source/core/css/resolver/CSSToStyleMap.cpp

index 4b6cae74de52dccf06e8c844e8d384739bfbcbaa..3258eaea2a4daf6cf040168b428209dffba8e8f7 100644

--- a/third_party/WebKit/Source/core/css/resolver/CSSToStyleMap.cpp

+++ b/third_party/WebKit/Source/core/css/resolver/CSSToStyleMap.cpp

@@ -134,7 +134,7 @@ void CSSToStyleMap::mapFillImage(StyleResolverState& state, FillLayer* layer, CS

}

CSSPropertyID property = layer->type() == BackgroundFillLayer ? CSSPropertyBackgroundImage : CSSPropertyWebkitMaskImage;

- layer->setImage(state.styleImage(property, value));

+ layer->setImage(state.styleImage(property, *value));

}

void CSSToStyleMap::mapFillRepeatX(StyleResolverState&, FillLayer* layer, CSSValue* value)

@@ -445,7 +445,7 @@ void CSSToStyleMap::mapNinePieceImage(StyleResolverState& state, CSSPropertyID p

CSSValue* current = borderImage->item(i);

if (current->isImageValue() || current->isImageGeneratorValue() || current->isImageSetValue())

- image.setImage(state.styleImage(imageProperty, current));

+ image.setImage(state.styleImage(imageProperty, *current));

else if (current->isBorderImageSliceValue())

mapNinePieceImageSlice(state, current, image);

else if (current->isValueList()) {