Issue 13871008: Change cctest/test-lockers to not rely on casting Handle to Persistent

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 13871008: Change cctest/test-lockers to not rely on casting Handle to Persistent (Closed)

Created:
7 years, 8 months ago by jochen (gone - plz use gerrit)

Modified:
7 years, 8 months ago

Reviewers:
Sven Panne

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Change cctest/test-lockers to not rely on casting Handle to Persistent In a future patch, I want to remove the cast operator entirely. Currently, WebKit's minor gc implementation still relies on this, so we need to fix that first.

Patch Set 1 #

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+26 lines, -5 lines)			Patch
	M	test/cctest/test-lockers.cc	View		4 chunks	+26 lines, -5 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Sven Panne

7 years, 8 months ago (2013-04-25 06:38:51 UTC) #2

Can we close this CL after https://codereview.chromium.org/14150017/ has been
landed?

Expand Messages | Collapse Messages