Change cctest/test-lockers to not rely on casting Handle to Persistent

test/cctest/test-lockers.cc

 // Copyright 2007-2011 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 43 matching lines @@
 using ::v8::Value;
 using ::v8::V8;
 
 
 // Migrating an isolate
 class KangarooThread : public v8::internal::Thread {
  public:
   KangarooThread(v8::Isolate* isolate,
                  v8::Handle<v8::Context> context)
       : Thread("KangarooThread"),
-        isolate_(isolate), context_(context) {
+        isolate_(isolate),
+        context_(v8::Persistent<v8::Context>::New(isolate, context)) {
+  }
+
+  virtual ~KangarooThread() {
+    context_.Dispose(isolate_);
+    context_.Clear();
   }
 
   void Run() {
     {
       v8::Locker locker(isolate_);
       v8::Isolate::Scope isolate_scope(isolate_);
       CHECK_EQ(isolate_, v8::internal::Isolate::Current());
       v8::HandleScope scope(isolate_);
       v8::Context::Scope context_scope(context_);
       Local<Value> v = CompileRun("getValue()");
@@ skipping 260 matching lines @@
   isolate2->Dispose();
   isolate1->Dispose();
 }
 
 class LockIsolateAndCalculateFibSharedContextThread : public JoinableThread {
  public:
   explicit LockIsolateAndCalculateFibSharedContextThread(
       v8::Isolate* isolate, v8::Handle<v8::Context> context)
     : JoinableThread("LockIsolateAndCalculateFibThread"),
       isolate_(isolate),
-      context_(context) {
+      context_(v8::Persistent<v8::Context>::New(isolate, context)) {
+  }
+  virtual ~LockIsolateAndCalculateFibSharedContextThread() {
+    context_.Dispose(isolate_);
+    context_.Clear();
   }
 
   virtual void Run() {
     v8::Locker lock(isolate_);
     v8::Isolate::Scope isolate_scope(isolate_);
     HandleScope handle_scope(isolate_);
     v8::Context::Scope context_scope(context_);
     CalcFibAndCheck();
   }
  private:
@@ skipping 168 matching lines @@
   thread.Join();
   isolate2->Dispose();
   isolate1->Dispose();
 }
 
 class LockUnlockLockThread : public JoinableThread {
  public:
   LockUnlockLockThread(v8::Isolate* isolate, v8::Handle<v8::Context> context)
     : JoinableThread("LockUnlockLockThread"),
       isolate_(isolate),
-      context_(context) {
+      context_(v8::Persistent<v8::Context>::New(isolate, context)) {
+  }
+
+  virtual ~LockUnlockLockThread() {
+    context_.Dispose(isolate_);
+    context_.Clear();
   }
 
   virtual void Run() {
     v8::Locker lock1(isolate_);
     CHECK(v8::Locker::IsLocked(isolate_));
     CHECK(!v8::Locker::IsLocked(CcTest::default_isolate()));
     {
       v8::Isolate::Scope isolate_scope(isolate_);
       v8::HandleScope handle_scope(isolate_);
       v8::Context::Scope context_scope(context_);
@@ skipping 39 matching lines @@
   for (int i = 0; i < kNThreads; i++) {
     threads.Add(new LockUnlockLockThread(isolate, context));
   }
   StartJoinAndDeleteThreads(threads);
   isolate->Dispose();
 }
 
 class LockUnlockLockDefaultIsolateThread : public JoinableThread {
  public:
   explicit LockUnlockLockDefaultIsolateThread(v8::Handle<v8::Context> context)
-    : JoinableThread("LockUnlockLockDefaultIsolateThread"),
-      context_(context) {
+      : JoinableThread("LockUnlockLockDefaultIsolateThread"),
+        context_(v8::Persistent<v8::Context>::New(CcTest::default_isolate(),
+                                                  context)) {
+  }
+
+  virtual ~LockUnlockLockDefaultIsolateThread() {
+    context_.Dispose(CcTest::default_isolate());
+    context_.Clear();
   }
 
   virtual void Run() {
     v8::Locker lock1(CcTest::default_isolate());
     {
       v8::HandleScope handle_scope(CcTest::default_isolate());
       v8::Context::Scope context_scope(context_);
       CalcFibAndCheck();
     }
     {
@@ skipping 108 matching lines @@
                                           kSimpleExtensionSource));
   const char* extension_names[] = { "test0", "test1",
                                     "test2", "test3", "test4",
                                     "test5", "test6", "test7" };
   i::List<JoinableThread*> threads(kNThreads);
   for (int i = 0; i < kNThreads; i++) {
     threads.Add(new IsolateGenesisThread(8, extension_names));
   }
   StartJoinAndDeleteThreads(threads);
 }