Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(61)

Unified Diff: tests/PathTest.cpp

Issue 138703008: fix minor error between kStroke_PathAsRect and kFill_PathAsRect in SkPath::asRect (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« src/core/SkPath.cpp ('K') | « src/core/SkPath.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tests/PathTest.cpp
diff --git a/tests/PathTest.cpp b/tests/PathTest.cpp
index e872b0c839699f307c70f2e3ace1b3c3256da35a..f9466f5944f6c074a666887599f6b9d9cb006e1b 100644
--- a/tests/PathTest.cpp
+++ b/tests/PathTest.cpp
@@ -1443,7 +1443,7 @@ static void test_isRect_open_close(skiatest::Reporter* reporter) {
REPORTER_ASSERT(reporter, path.isRect(NULL, NULL));
REPORTER_ASSERT(reporter, path.isRect(&isClosed, NULL));
REPORTER_ASSERT(reporter, isClosed);
- REPORTER_ASSERT(reporter, SkPath::kFill_PathAsRect == path.asRect(NULL));
+ REPORTER_ASSERT(reporter, SkPath::kStroke_PathAsRect == path.asRect(NULL));
}
// Simple isRect test is inline TestPath, below.
@@ -1562,7 +1562,7 @@ static void test_isRect(skiatest::Reporter* reporter) {
REPORTER_ASSERT(reporter, isClosed == tests[testIndex].fClose);
REPORTER_ASSERT(reporter, direction == cheapDirection);
direction = (SkPath::Direction) -1;
- if (tests[testIndex].fClose) {
+ if (!tests[testIndex].fClose) {
REPORTER_ASSERT(reporter, SkPath::kFill_PathAsRect == path.asRect());
REPORTER_ASSERT(reporter, SkPath::kFill_PathAsRect == path.asRect(&direction));
} else {
« src/core/SkPath.cpp ('K') | « src/core/SkPath.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698