Fix SkGifCodec to handle gifs where frameSize != imageSize

Fix SkGifCodec to handle gifs where frameSize != imageSize

These are quite rare, causing us to miss a few bugs in how
we deal with these images.

Additionally, there is a behavior change.  If the imageSize
is not large enough to contain the frame, we will "fix" the
image by increasing the image size.

SkScaledCodec is still buggy with regard to these gifs.
See skbug.com/4421. We will fix that after 1332053002
lands.

BUG=skia:

Committed: https://skia.googlesource.com/skia/+/4aa02d8e73229aeb13f5de6c6de6f5aef061b0d5

[msarett, 2015-10-05 20:50:34]

Patchset #1 (id:1) has been deleted

[msarett, 2015-10-05 20:50:42]

Patchset #1 (id:20001) has been deleted

[msarett, 2015-10-05 20:56:56]

Patchset #1 (id:40001) has been deleted

[msarett, 2015-10-05 20:59:32]

msarett@google.com changed reviewers:
+ scroggo@google.com

[msarett, 2015-10-05 20:59:32]

https://codereview.chromium.org/1386973002/diff/60001/src/codec/SkCodec_libgi...
File src/codec/SkCodec_libgif.cpp (right):

https://codereview.chromium.org/1386973002/diff/60001/src/codec/SkCodec_libgi...
src/codec/SkCodec_libgif.cpp:596: SkSwizzler::Fill(dst,
this->dstInfo().makeWH(fFrameRect.width(),
This will be deleted soon anyway, but I'll go ahead and fix it.

https://codereview.chromium.org/1386973002/diff/60001/src/codec/SkCodec_libgi...
src/codec/SkCodec_libgif.cpp:616: int nextScanline =
this->INHERITED::onNextScanline();
This is unfortunate because I think it means that onNextScanline() must be
virtual.

I made it non-virtual in my Fill() CL.

[reed1, 2015-10-05 21:08:12]

reed@google.com changed reviewers:
+ reed@google.com

[reed1, 2015-10-05 21:08:12]

lgtm

https://codereview.chromium.org/1386973002/diff/60001/src/codec/SkCodec_libgif.h
File src/codec/SkCodec_libgif.h (right):

https://codereview.chromium.org/1386973002/diff/60001/src/codec/SkCodec_libgi...
src/codec/SkCodec_libgif.h:98: static bool SetDimensions(GifFileType* gif,
SkISize* size, SkIRect* frameRect);
Seems like GetDimensions would be clearer.

[reed1, 2015-10-05 21:08:23]

not lgtm (per-se)

[reed1, 2015-10-05 21:08:58]

reed@google.com changed required reviewers:
+ scroggo@google.com

[reed1, 2015-10-05 21:08:59]

aw heck ... lgtm

[scroggo, 2015-10-06 12:57:37]

lgtm

https://codereview.chromium.org/1386973002/diff/60001/src/codec/SkCodec_libgif.h
File src/codec/SkCodec_libgif.h (right):

https://codereview.chromium.org/1386973002/diff/60001/src/codec/SkCodec_libgi...
src/codec/SkCodec_libgif.h:88: * them if necessary.
Hmm, it seems like we correct size, rather than the frame dimensions?

https://codereview.chromium.org/1386973002/diff/60001/src/codec/SkCodec_libgi...
src/codec/SkCodec_libgif.h:93: * @param frameRect Contains the dimenions and
offset the first image frame.
of* the first image frame

[msarett, 2015-10-06 14:39:17]

https://codereview.chromium.org/1386973002/diff/60001/src/codec/SkCodec_libgif.h
File src/codec/SkCodec_libgif.h (right):

https://codereview.chromium.org/1386973002/diff/60001/src/codec/SkCodec_libgi...
src/codec/SkCodec_libgif.h:88: * them if necessary.
On 2015/10/06 12:57:37, scroggo wrote:
> Hmm, it seems like we correct size, rather than the frame dimensions?

Yes, will change this comment.

https://codereview.chromium.org/1386973002/diff/60001/src/codec/SkCodec_libgi...
src/codec/SkCodec_libgif.h:93: * @param frameRect Contains the dimenions and
offset the first image frame.
On 2015/10/06 12:57:37, scroggo wrote:
> of* the first image frame

Done.

https://codereview.chromium.org/1386973002/diff/60001/src/codec/SkCodec_libgi...
src/codec/SkCodec_libgif.h:98: static bool SetDimensions(GifFileType* gif,
SkISize* size, SkIRect* frameRect);
On 2015/10/05 21:08:12, reed1 wrote:
> Seems like GetDimensions would be clearer.

Done.

[msarett, 2015-10-06 14:39:31]

The CQ bit was checked by msarett@google.com

[msarett, 2015-10-06 14:39:31]

The patchset sent to the CQ was uploaded after l-g-t-m from scroggo@google.com,
reed@google.com
Link to the patchset: https://codereview.chromium.org/1386973002/#ps80001
(title: " ")

[commit-bot: I haz the power, 2015-10-06 14:39:39]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1386973002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1386973002/80001

[commit-bot: I haz the power, 2015-10-06 14:46:05]

Committed patchset #2 (id:80001) as
https://skia.googlesource.com/skia/+/4aa02d8e73229aeb13f5de6c6de6f5aef061b0d5