third_party/WebKit/Source/build/scripts/templates/CSSPropertyMetadata.cpp.tmpl - Issue 1386733003: Do not accept CSS-wide keywords for descriptors

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/Source/build/scripts/templates/CSSPropertyMetadata.cpp.tmpl

Issue 1386733003: Do not accept CSS-wide keywords for descriptors (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Try to fix ASSERTs Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « third_party/WebKit/Source/build/scripts/make_style_builder.py ('k') | third_party/WebKit/Source/core/css/CSSProperties.in » ('j') | third_party/WebKit/Source/core/css/CSSProperties.in » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 {% from 'macros.tmpl' import license %}	1 {% from 'macros.tmpl' import license %}

2 {{license()}}	2 {{license()}}

3	3

4 #include "core/css/CSSPropertyMetadata.h"	4 #include "core/css/CSSPropertyMetadata.h"

5	5

6 #include "platform/RuntimeEnabledFeatures.h"	6 #include "platform/RuntimeEnabledFeatures.h"

7 #include <bitset>	7 #include <bitset>

8	8

9 namespace blink {	9 namespace blink {

10 {% for flag, function_name in switches %}	10 {% for flag, function_name in switches %}

(...skipping 44 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
55	55

56 void CSSPropertyMetadata::filterEnabledCSSPropertiesIntoVector(const CSSProperty ID* properties, size_t propertyCount, Vector<CSSPropertyID>& outVector)	56 void CSSPropertyMetadata::filterEnabledCSSPropertiesIntoVector(const CSSProperty ID* properties, size_t propertyCount, Vector<CSSPropertyID>& outVector)

57 {	57 {

58 for (unsigned i = 0; i < propertyCount; i++) {	58 for (unsigned i = 0; i < propertyCount; i++) {

59 CSSPropertyID property = properties[i];	59 CSSPropertyID property = properties[i];

60 if (isEnabledProperty(property))	60 if (isEnabledProperty(property))

61 outVector.append(property);	61 outVector.append(property);

62 }	62 }

63 }	63 }

64	64

	65 bool CSSPropertyMetadata::isDescriptor(CSSPropertyID property)
	Timothy Loh 2016/05/31 03:24:05 let's rename this to isDecriptorOnly (similar to t let's rename this to isDecriptorOnly (similar to the flag)
	66 {

	67 return property >= {{descriptors[0].property_id}} && property <= {{descripto rs[-1].property_id}};

	68 }

	69

65 } // namespace blink	70 } // namespace blink

OLD	NEW