Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(260)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 138673005: Call RemoveObserver in AndroidSigninManager (Closed)

Created:
6 years, 11 months ago by acleung1
Modified:
6 years, 11 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Call RemoveObserver in AndroidSigninManager BUG=334424 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=245367

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M chrome/browser/android/signin/signin_manager_android.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
acleung1
6 years, 11 months ago (2014-01-14 22:12:37 UTC) #1
Roger Tawa OOO till Jul 10th
Lgtm Good catch!
6 years, 11 months ago (2014-01-15 14:04:19 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/acleung@chromium.org/138673005/1
6 years, 11 months ago (2014-01-15 22:17:04 UTC) #3
commit-bot: I haz the power
Retried try job too often on chromium_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_presubmit&number=44967
6 years, 11 months ago (2014-01-15 23:49:39 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/acleung@chromium.org/138673005/1
6 years, 11 months ago (2014-01-16 00:06:27 UTC) #5
commit-bot: I haz the power
Retried try job too often on chromium_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_presubmit&number=44989
6 years, 11 months ago (2014-01-16 01:25:14 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/acleung@chromium.org/138673005/1
6 years, 11 months ago (2014-01-16 21:34:32 UTC) #7
acleung1
Hey Tommy can I get an OWNER lgtm?
6 years, 11 months ago (2014-01-16 21:37:56 UTC) #8
nyquist
lgtm
6 years, 11 months ago (2014-01-16 21:39:08 UTC) #9
commit-bot: I haz the power
6 years, 11 months ago (2014-01-16 23:06:26 UTC) #10
Message was sent while issue was closed. 
Change committed as 245367

Powered by Google App Engine
This is Rietveld 408576698