chrome/browser/android/signin/signin_manager_android.cc - Issue 138673005: Call RemoveObserver in AndroidSigninManager

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/android/signin/signin_manager_android.cc

Issue 138673005: Call RemoveObserver in AndroidSigninManager (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/android/signin/signin_manager_android.cc

diff --git a/chrome/browser/android/signin/signin_manager_android.cc b/chrome/browser/android/signin/signin_manager_android.cc

index 6ec2a42c2707c0df45e86d13729ddd7088b706ad..a4a3abbcdc011f231b1f48aa0029f6e00d7aeaac 100644

--- a/chrome/browser/android/signin/signin_manager_android.cc

+++ b/chrome/browser/android/signin/signin_manager_android.cc

@@ -208,6 +208,7 @@ void SigninManagerAndroid::OnBrowsingDataRemoverDone() {

void SigninManagerAndroid::MergeSessionCompleted(

const std::string& account_id,

const GoogleServiceAuthError& error) {

+ merge_session_helper_->RemoveObserver(this);

merge_session_helper_.reset();

}

« no previous file with comments | « no previous file | no next file » | no next file with comments »