Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(265)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1386703002: Move rotation property handling into CSSPropertyParser (Closed)

Created:
5 years, 2 months ago by rwlbuis
Modified:
5 years, 2 months ago
CC:
blink-reviews, blink-reviews-css, dglazkov+blink, apavlov+blink_chromium.org, darktears, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move rotation property handling into CSSPropertyParser Move rotation property handling from LegacyCSSPropertyParser into CSSPropertyParser. BUG=499780 Committed: https://crrev.com/aff0c1284bb8d6f9399a7de9bf56a42d6aa4d230 Cr-Commit-Position: refs/heads/master@{#352250}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -25 lines) Patch
M third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp View 3 chunks +47 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/css/parser/LegacyCSSPropertyParser.cpp View 2 chunks +1 line, -25 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
rwlbuis
PTAL, should be pretty straightforward. Note that I don't think we actually test angle + ...
5 years, 2 months ago (2015-10-02 21:07:08 UTC) #2
Timothy Loh
On 2015/10/02 21:07:08, rwlbuis wrote: > PTAL, should be pretty straightforward. > Note that I ...
5 years, 2 months ago (2015-10-03 04:27:48 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1386703002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1386703002/1
5 years, 2 months ago (2015-10-03 07:36:01 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-10-03 08:56:53 UTC) #6
commit-bot: I haz the power
5 years, 2 months ago (2015-10-03 08:57:32 UTC) #7
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/aff0c1284bb8d6f9399a7de9bf56a42d6aa4d230
Cr-Commit-Position: refs/heads/master@{#352250}

Powered by Google App Engine
This is Rietveld 408576698