Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(213)

Unified Diff: third_party/WebKit/Source/core/css/parser/LegacyCSSPropertyParser.cpp

Issue 1386703002: Move rotation property handling into CSSPropertyParser (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/css/parser/LegacyCSSPropertyParser.cpp
diff --git a/third_party/WebKit/Source/core/css/parser/LegacyCSSPropertyParser.cpp b/third_party/WebKit/Source/core/css/parser/LegacyCSSPropertyParser.cpp
index 3ea7e7dd7204dc24fc23ccc51524d01de7d1a1e1..d23f9a0d730630f9196c543fd6d5371a524537da 100644
--- a/third_party/WebKit/Source/core/css/parser/LegacyCSSPropertyParser.cpp
+++ b/third_party/WebKit/Source/core/css/parser/LegacyCSSPropertyParser.cpp
@@ -1017,31 +1017,6 @@ bool CSSPropertyParser::parseValue(CSSPropertyID unresolvedProperty, bool import
break;
}
- case CSSPropertyRotate: { // rotate : <angle> <number>{3}? defaults to a 0 0 1
- ASSERT(RuntimeEnabledFeatures::cssIndependentTransformPropertiesEnabled());
- RefPtrWillBeRawPtr<CSSValueList> list = CSSValueList::createSpaceSeparated();
-
- if (!validUnit(value, FAngle))
- return false;
- list->append(createPrimitiveNumericValue(value));
- value = m_valueList->next();
-
- if (!value) {
- parsedValue = list.release();
- break;
- }
-
- for (unsigned i = 0; i < 3; i++) { // 3 dimensions of rotation
- if (!value || !validUnit(value, FNumber))
- return false;
- list->append(createPrimitiveNumericValue(value));
- value = m_valueList->next();
- }
-
- parsedValue = list.release();
- break;
- }
-
case CSSPropertyScale: { // scale: <number>{1,3}, default scale for all axis is 1
ASSERT(RuntimeEnabledFeatures::cssIndependentTransformPropertiesEnabled());
RefPtrWillBeRawPtr<CSSValueList> scaleList = CSSValueList::createSpaceSeparated();
@@ -1410,6 +1385,7 @@ bool CSSPropertyParser::parseValue(CSSPropertyID unresolvedProperty, bool import
case CSSPropertyTabSize:
case CSSPropertyFontSize:
case CSSPropertyLineHeight:
+ case CSSPropertyRotate:
validPrimitive = false;
break;
« no previous file with comments | « third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698