ash: Fix transient child in wrong workspace.

ash: Fix transient child in wrong workspace.

Persists-across-all-workspace flag should not cause workspace switch when
showing a transient child of a maximized transient parent.

BUG=232119
TEST=Covered in a new test.

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=194603

[xiyuan, 2013-04-16 22:28:41]

In ash, all windows are persists across all workspace by default (except certain
browser windows). One scenario I have is a maximized extension app window that
triggers its permission dialog. Both windows are persists across all workspace.
When the permission dialog is activated, workspace is changed. The change is
because Workspace::ShouldMoveToPending returns true, which in turn is because we
have only one tracked, maximized, persists window in that workspace and maxmized
flag is only checked for untracked window now.

The CL makes the maximized check for both tracked and untracked window in the
workspace. And all tests are passing.

[sky, 2013-04-16 22:33:24]

https://codereview.chromium.org/13867010/diff/1/ash/wm/workspace/workspace.cc
File ash/wm/workspace/workspace.cc (right):

https://codereview.chromium.org/13867010/diff/1/ash/wm/workspace/workspace.cc...
ash/wm/workspace/workspace.cc:82: if (WorkspaceManager::IsMaximized(child))
I think this is going to break dragging a tab from a maximized window.

[xiyuan, 2013-04-16 22:52:49]

https://codereview.chromium.org/13867010/diff/1/ash/wm/workspace/workspace.cc
File ash/wm/workspace/workspace.cc (right):

https://codereview.chromium.org/13867010/diff/1/ash/wm/workspace/workspace.cc...
ash/wm/workspace/workspace.cc:82: if (WorkspaceManager::IsMaximized(child))
On 2013/04/16 22:33:25, sky wrote:
> I think this is going to break dragging a tab from a maximized window.

I verified it still works. You can drag a tab out of a maxmized browser window.
Drop it will switch to desktop workspace. The last tab in maximized window is
not allowed to be detached. 

It looks like the essence of r189849 (your CL that fixes the tab dragging issue)
is that we don't skip untracked window for maxmized test. The CL preserves that
and things should work. The added test in r189849 passes without modification.

[sky, 2013-04-16 23:23:30]

LGTM

https://codereview.chromium.org/13867010/diff/1/ash/wm/workspace/workspace.cc
File ash/wm/workspace/workspace.cc (right):

https://codereview.chromium.org/13867010/diff/1/ash/wm/workspace/workspace.cc...
ash/wm/workspace/workspace.cc:82: if (WorkspaceManager::IsMaximized(child))
On 2013/04/16 22:52:49, xiyuan wrote:
> On 2013/04/16 22:33:25, sky wrote:
> > I think this is going to break dragging a tab from a maximized window.
> 
> I verified it still works. You can drag a tab out of a maxmized browser
window.
> Drop it will switch to desktop workspace. The last tab in maximized window is
> not allowed to be detached. 
> 
> It looks like the essence of r189849 (your CL that fixes the tab dragging
issue)
> is that we don't skip untracked window for maxmized test. The CL preserves
that
> and things should work. The added test in r189849 passes without modification.

Good point.

[xiyuan, 2013-04-17 16:01:47]

Committed patchset #1 manually as r194603 (presubmit successful).