ash: Fix transient child in wrong workspace.

ash/wm/workspace/workspace.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ash/wm/workspace/workspace.h"
 
 #include "ash/shell_window_ids.h"
 #include "ash/wm/property_util.h"
 #include "ash/wm/window_animations.h"
 #include "ash/wm/window_properties.h"
@@ skipping 60 matching lines @@
 
 bool Workspace::ShouldMoveToPending() const {
   if (!is_maximized_)
     return false;
 
   for (size_t i = 0; i < window_->children().size(); ++i) {
     aura::Window* child(window_->children()[i]);
     if (!child->TargetVisibility() || wm::IsWindowMinimized(child))
       continue;
 
-    if (!GetTrackedByWorkspace(child)) {
-      // If we have a maximized window that isn't tracked don't move to
-      // pending. This handles the case of dragging a maximized window.
-      if (WorkspaceManager::IsMaximized(child))
-        return false;
-      continue;
-    }
+    // If we have a maximized window don't move to pending.
+    if (WorkspaceManager::IsMaximized(child))

[sky, 2013/04/16 22:33:25]

I think this is going to break dragging a tab from a maximized window.

[xiyuan, 2013/04/16 22:52:49]

I verified it still works. You can drag a tab out of a maxmized browser window.
Drop it will switch to desktop workspace. The last tab in maximized window is
not allowed to be detached. 

It looks like the essence of r189849 (your CL that fixes the tab dragging issue)
is that we don't skip untracked window for maxmized test. The CL preserves that
and things should work. The added test in r189849 passes without modification.

[sky, 2013/04/16 23:23:30]

Good point.

+      return false;
 
-    if (!GetPersistsAcrossAllWorkspaces(child))
+    if (GetTrackedByWorkspace(child) && !GetPersistsAcrossAllWorkspaces(child))
       return false;
   }
   return true;
 }
 
 int Workspace::GetNumMaximizedWindows() const {
   int count = 0;
   for (size_t i = 0; i < window_->children().size(); ++i) {
     aura::Window* child = window_->children()[i];
     if (GetTrackedByWorkspace(child) &&
         (WorkspaceManager::IsMaximized(child) ||
          WorkspaceManager::WillRestoreMaximized(child))) {
       if (++count == 2)
         return count;
     }
   }
   return count;
 }
 
 }  // namespace internal
 }  // namespace ash