Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(339)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1386643002: S4 only has 8 texture units on the GLContext we create (Closed)

Created:
5 years, 2 months ago by joshua.litt
Modified:
5 years, 2 months ago
Reviewers:
joshualitt, bsalomon
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

S4 only has 8 texture units on the GLContext we create BUG=skia:4373 Committed: https://skia.googlesource.com/skia/+/b235168f55a4a1aa8682ef761be8a7730cb52200

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M bench/GLBench.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
joshualitt
5 years, 2 months ago (2015-10-02 13:42:00 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1386643002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1386643002/1
5 years, 2 months ago (2015-10-02 13:42:29 UTC) #4
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
5 years, 2 months ago (2015-10-02 13:42:30 UTC) #5
bsalomon
On 2015/10/02 13:42:30, commit-bot: I haz the power wrote: > Note for Reviewers: > The ...
5 years, 2 months ago (2015-10-02 13:48:02 UTC) #6
commit-bot: I haz the power
5 years, 2 months ago (2015-10-02 13:49:34 UTC) #7
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/b235168f55a4a1aa8682ef761be8a7730cb52200

Powered by Google App Engine
This is Rietveld 408576698