Issue 13866044: Add cpplint to presubmit input_api

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 13866044: Add cpplint to presubmit input_api (Closed)

Created:
7 years, 8 months ago by enne (OOO)

Modified:
7 years, 8 months ago

Reviewers:
M-A Ruel

CC:
chromium-reviews, Dirk Pranke, cmp-cc_chromium.org, M-A Ruel, iannucci+depot_tools_chromium.org, danakj, Elliot Glaysher

Base URL:
svn://svn.chromium.org/chrome/trunk/tools/depot_tools

Visibility:
Public.

More Reviews

Description

Add cpplint to presubmit input_api This will let clients that don't use the heavily filtered canned cpplint check and want to behave more strictly (aka cc/) reuse any common settings applied to the cpplint module. R=maruel@chromium.org BUG=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=194264

Patch Set 1 #

Total comments: 2

Patch Set 2 : bump version #

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+26 lines, -24 lines)			Patch
M	presubmit_canned_checks.py	View		2 chunks	+1 line, -10 lines	0 comments	Download
M	presubmit_support.py	View	1	3 chunks	+13 lines, -1 line	0 comments	Download
M	tests/presubmit_unittest.py	View		2 chunks	+12 lines, -13 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

M-A Ruel

lgtm https://codereview.chromium.org/13866044/diff/1/presubmit_support.py File presubmit_support.py (right): https://codereview.chromium.org/13866044/diff/1/presubmit_support.py#newcode9 presubmit_support.py:9: __version__ = '1.6.1' bump the number

7 years, 8 months ago (2013-04-15 23:25:22 UTC) #2

enne (OOO)

https://codereview.chromium.org/13866044/diff/1/presubmit_support.py File presubmit_support.py (right): https://codereview.chromium.org/13866044/diff/1/presubmit_support.py#newcode9 presubmit_support.py:9: __version__ = '1.6.1' On 2013/04/15 23:25:22, Marc-Antoine Ruel wrote: ...

7 years, 8 months ago (2013-04-15 23:28:41 UTC) #3

enne (OOO)

7 years, 8 months ago (2013-04-16 00:36:43 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 manually as r194264 (presubmit successful).

Expand Messages | Collapse Messages