Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(355)

Unified Diff: tests/presubmit_unittest.py

Issue 13866044: Add cpplint to presubmit input_api (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/depot_tools
Patch Set: bump version Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « presubmit_support.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tests/presubmit_unittest.py
diff --git a/tests/presubmit_unittest.py b/tests/presubmit_unittest.py
index dc5c8540469fe290319415990bc9b6b2afcbc6bd..243c9070f07020ced507906f2e6236a6220bc43b 100755
--- a/tests/presubmit_unittest.py
+++ b/tests/presubmit_unittest.py
@@ -161,14 +161,13 @@ class PresubmitUnittest(PresubmitTestsBase):
'GitChange', 'InputApi', 'ListRelevantPresubmitFiles', 'Main',
'NonexistantCannedCheckFilter', 'OutputApi', 'ParseFiles',
'PresubmitFailure', 'PresubmitExecuter', 'PresubmitOutput', 'ScanSubDirs',
- 'SvnAffectedFile', 'SvnChange', 'cPickle', 'cStringIO', 'contextlib',
- 'canned_check_filter', 'fix_encoding', 'fnmatch', 'gclient_utils', 'glob',
- 'inspect', 'json', 'load_files',
- 'logging', 'marshal', 'normpath', 'optparse', 'os', 'owners', 'pickle',
+ 'SvnAffectedFile', 'SvnChange', 'cPickle', 'cpplint', 'cStringIO',
+ 'contextlib', 'canned_check_filter', 'fix_encoding', 'fnmatch',
+ 'gclient_utils', 'glob', 'inspect', 'json', 'load_files', 'logging',
+ 'marshal', 'normpath', 'optparse', 'os', 'owners', 'pickle',
'presubmit_canned_checks', 'random', 're', 'rietveld', 'scm',
- 'subprocess',
- 'sys', 'tempfile', 'time', 'traceback', 'types', 'unittest', 'urllib2',
- 'warn',
+ 'subprocess', 'sys', 'tempfile', 'time', 'traceback', 'types', 'unittest',
+ 'urllib2', 'warn',
]
# If this test fails, you should add the relevant test.
self.compareMembers(presubmit, members)
@@ -884,12 +883,12 @@ class InputApiUnittest(PresubmitTestsBase):
'DepotToLocalPath', 'FilterSourceFile', 'LocalPaths',
'LocalToDepotPath',
'PresubmitLocalPath', 'ReadFile', 'RightHandSideLines', 'ServerPaths',
- 'basename', 'cPickle', 'cStringIO', 'canned_checks', 'change', 'environ',
- 'glob', 'host_url', 'is_committing', 'json', 'logging', 'marshal',
- 'os_listdir', 'os_walk',
- 'os_path', 'owners_db', 'pickle', 'platform', 'python_executable', 're',
- 'rietveld', 'subprocess', 'tbr', 'tempfile', 'time', 'traceback',
- 'unittest', 'urllib2', 'version', 'verbose',
+ 'basename', 'cPickle', 'cpplint', 'cStringIO', 'canned_checks', 'change',
+ 'environ', 'glob', 'host_url', 'is_committing', 'json', 'logging',
+ 'marshal', 'os_listdir', 'os_walk', 'os_path', 'owners_db', 'pickle',
+ 'platform', 'python_executable', 're', 'rietveld', 'subprocess', 'tbr',
+ 'tempfile', 'time', 'traceback', 'unittest', 'urllib2', 'version',
+ 'verbose',
]
# If this test fails, you should add the relevant test.
self.compareMembers(
« no previous file with comments | « presubmit_support.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698