Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(649)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 13866038: Revert 148069 and 148060 to see if they were responsible for a perf regression (Closed)

Created:
7 years, 8 months ago by Nate Chapin
Modified:
7 years, 8 months ago
Reviewers:
eseidel
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, alph+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, gavinp+loader_chromium.org, aandrey+blink_chromium.org
Visibility:
Public.

Description

Revert 148069 and 148060 to see if they were responsible for a perf regression BUG=230225 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=148231

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+417 lines, -257 lines) Patch
M Source/WebCore/WebCore.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M Source/WebCore/inspector/InspectorResourceAgent.cpp View 2 chunks +2 lines, -1 line 0 comments Download
M Source/WebCore/loader/DocumentLoader.h View 2 chunks +4 lines, -4 lines 0 comments Download
M Source/WebCore/loader/DocumentLoader.cpp View 11 chunks +20 lines, -20 lines 0 comments Download
M Source/WebCore/loader/DocumentThreadableLoader.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/WebCore/loader/ResourceLoader.h View 5 chunks +24 lines, -10 lines 0 comments Download
M Source/WebCore/loader/ResourceLoader.cpp View 9 chunks +87 lines, -187 lines 0 comments Download
A + Source/WebCore/loader/SubresourceLoader.h View 2 chunks +26 lines, -26 lines 0 comments Download
A Source/WebCore/loader/SubresourceLoader.cpp View 1 chunk +235 lines, -0 lines 0 comments Download
M Source/WebCore/loader/cache/CachedImage.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/WebCore/loader/cache/CachedRawResource.h View 2 chunks +2 lines, -0 lines 0 comments Download
M Source/WebCore/loader/cache/CachedRawResource.cpp View 2 chunks +6 lines, -1 line 0 comments Download
M Source/WebCore/loader/cache/CachedResource.h View 3 chunks +3 lines, -3 lines 0 comments Download
M Source/WebCore/loader/cache/CachedResource.cpp View 2 chunks +4 lines, -2 lines 0 comments Download
M Source/WebKit/chromium/src/AssociatedURLLoader.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (0 generated)
Nate Chapin
7 years, 8 months ago (2013-04-11 18:56:43 UTC) #1
eseidel
lgtm
7 years, 8 months ago (2013-04-11 20:24:55 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/japhet@chromium.org/13866038/1
7 years, 8 months ago (2013-04-11 20:25:09 UTC) #3
commit-bot: I haz the power
Presubmit check for 13866038-1 failed and returned exit status -2001. The presubmit check was hung. ...
7 years, 8 months ago (2013-04-11 20:31:18 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/japhet@chromium.org/13866038/1
7 years, 8 months ago (2013-04-11 20:37:20 UTC) #5
commit-bot: I haz the power
Presubmit check for 13866038-1 failed and returned exit status -2001. The presubmit check was hung. ...
7 years, 8 months ago (2013-04-11 20:43:25 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/japhet@chromium.org/13866038/1
7 years, 8 months ago (2013-04-11 20:50:23 UTC) #7
commit-bot: I haz the power
Presubmit check for 13866038-1 failed and returned exit status -2001. The presubmit check was hung. ...
7 years, 8 months ago (2013-04-11 20:56:35 UTC) #8
Nate Chapin
7 years, 8 months ago (2013-04-11 21:24:39 UTC) #9
Message was sent while issue was closed. 
Committed patchset #1 manually as r148231 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698