Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Issue 13866033: Animate the fullscreen exit bubble's opacity instead of its bounds when in immersive fullscreen (Closed)

Created:
7 years, 8 months ago by pkotwicz
Modified:
7 years, 8 months ago
CC:
chromium-reviews, tfarina
Base URL:
http://git.chromium.org/chromium/src.git@exit_bubble
Visibility:
Public.

Description

Animate the fullscreen exit bubble's opacity instead of its bounds when in immersive fullscreen. BUG=188567 Test=Manual, see instructions below. 1) Run Chrome with --ash-immersive-fullscreen 2) Go to http://html5-demos.appspot.com/static/fullscreen.html 3) Use F11 to toggle immersive fullscreen 4) With the top-of-window views closed, click on the "Toggle Fullscreen" button on the web page. 5) Hover at the top of the screen till the top-of-window views reveal. (Do this before the exit bubble fades out) Check that the exit fullscreen bubble animates with the top-of-window views. 6) Once the exit bubble disappears, check that it cannot be brought back by hovering at the top of the screen. 7) Exit tab fullscreen and browser fullscreen. 8) Enter tab fullscreen again by pressing the "Toggle fullscreen" button on the web page 9) Check that the exit fullscreen bubble slides in and out. (Note that when the exit bubble is initially shown it does not animate at all) 10) Go to chrome://settings > Show advanced settings... > Content settings... > Mouse cursor > Manage exceptions... 11) Remove an exception for www.html5rocks.com if there is one 12) Go to www.html5rocks.com/en/tutorials/pointerlock/intro 13) Use F11 to toggle immersive fullscreen 14) With the top-of-window views closed, click on the "Click me!" yellow box on the web page. (in the Interactive Example) section. 15) Hover at the top of the screen till the top-of-window views reveal. Check that the mouse lock bubble animates with the top-of-window views. 16) Click on the "Allow" button in the bubble. 17) Check that the mouse lock bubble fades out (as opposed to sliding out). 18) Press Escape and F11 to exit mouse lock and fullscreen 19) Click on the "Click me!" yellow box again. Check that the bubble slides out. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=195281

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Total comments: 4

Patch Set 5 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+231 lines, -54 lines) Patch
M chrome/browser/ui/fullscreen/fullscreen_exit_bubble.h View 1 chunk +8 lines, -3 lines 0 comments Download
M chrome/browser/ui/fullscreen/fullscreen_exit_bubble.cc View 1 2 3 4 2 chunks +10 lines, -4 lines 0 comments Download
M chrome/browser/ui/gtk/fullscreen_exit_bubble_gtk.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/gtk/fullscreen_exit_bubble_gtk.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/ui/views/frame/browser_view.h View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/frame/browser_view.cc View 1 2 3 4 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/fullscreen_exit_bubble_views.h View 1 2 3 4 4 chunks +45 lines, -9 lines 0 comments Download
M chrome/browser/ui/views/fullscreen_exit_bubble_views.cc View 1 2 3 4 7 chunks +160 lines, -35 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
pkotwicz
scheib@ and jamescook@ PTAL jamescook@, can you check that I have not missed any edge ...
7 years, 8 months ago (2013-04-10 18:34:40 UTC) #1
James Cook
LGTM from an immersive-fullscreen point of view scheib@, immersive fullscreen is basically a Chrome OS ...
7 years, 8 months ago (2013-04-10 20:47:58 UTC) #2
scheib
lgtm. Testing should also include pointer lock, which also uses the bubble. scheib.github.com/HTMLMisc/PointerLockAndFullscreen.html is one ...
7 years, 8 months ago (2013-04-10 22:23:19 UTC) #3
pkotwicz
https://codereview.chromium.org/13866033/diff/6001/chrome/browser/ui/views/fullscreen_exit_bubble_views.cc File chrome/browser/ui/views/fullscreen_exit_bubble_views.cc (right): https://codereview.chromium.org/13866033/diff/6001/chrome/browser/ui/views/fullscreen_exit_bubble_views.cc#newcode386 chrome/browser/ui/views/fullscreen_exit_bubble_views.cc:386: immersive_controller->AnchorWidgetToTopContainer(popup_, kPopupTopPx); By design, AnchorWidgetToTopContainer() is a noop outside ...
7 years, 8 months ago (2013-04-11 03:31:55 UTC) #4
pkotwicz
Ben for OWNERS
7 years, 8 months ago (2013-04-17 15:56:57 UTC) #5
scheib
On 2013/04/17 15:56:57, pkotwicz wrote: > Ben for OWNERS Please do adjust the issue summary ...
7 years, 8 months ago (2013-04-17 16:40:07 UTC) #6
pkotwicz
I have added testing with pointer lock in the test plan as requested
7 years, 8 months ago (2013-04-17 18:44:40 UTC) #7
Ben Goodger (Google)
https://codereview.chromium.org/13866033/diff/6001/chrome/browser/ui/views/fullscreen_exit_bubble_views.h File chrome/browser/ui/views/fullscreen_exit_bubble_views.h (right): https://codereview.chromium.org/13866033/diff/6001/chrome/browser/ui/views/fullscreen_exit_bubble_views.h#newcode12 chrome/browser/ui/views/fullscreen_exit_bubble_views.h:12: #include "chrome/browser/ui/views/frame/immersive_mode_controller.h" seems like these two #includes above can ...
7 years, 8 months ago (2013-04-18 17:56:01 UTC) #8
pkotwicz
Ben, can you please take another look? I made the change you requested. I also ...
7 years, 8 months ago (2013-04-19 16:11:27 UTC) #9
Ben Goodger (Google)
lgtm
7 years, 8 months ago (2013-04-19 16:14:20 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pkotwicz@chromium.org/13866033/21001
7 years, 8 months ago (2013-04-19 17:57:04 UTC) #11
commit-bot: I haz the power
7 years, 8 months ago (2013-04-19 21:07:41 UTC) #12
Message was sent while issue was closed.
Change committed as 195281

Powered by Google App Engine
This is Rietveld 408576698