Animate the fullscreen exit bubble's opacity instead of its bounds when in immersive fullscreen

chrome/browser/ui/fullscreen/fullscreen_exit_bubble.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/fullscreen/fullscreen_exit_bubble.h"
 
 #include "base/utf_string_conversions.h"
 #include "chrome/app/chrome_command_ids.h"
 #include "chrome/browser/profiles/profile.h"
 #include "chrome/browser/ui/browser.h"
@@ skipping 42 matching lines @@
       base::TimeDelta::FromMilliseconds(1000 / kPositionCheckHz), this,
       &FullscreenExitBubble::CheckMousePosition);
 }
 
 void FullscreenExitBubble::StopWatchingMouse() {
   initial_delay_.Stop();
   idle_timeout_.Stop();
   mouse_position_checker_.Stop();
 }
 
+bool FullscreenExitBubble::IsWatchingMouse() const {
+  return mouse_position_checker_.IsRunning();
+}
+
 void FullscreenExitBubble::CheckMousePosition() {
   // Desired behavior:
   //
   // +------------+-----------------------------+------------+
   // | _  _  _  _ | Exit full screen mode (F11) | _  _  _  _ |  Slide-in region
   // | _  _  _  _ \_____________________________/ _  _  _  _ |  Neutral region
   // |                                                       |  Slide-out region
   // :                                                       :
   //
   // * If app is not active, we hide the popup.
@@ skipping 21 matching lines @@
   last_mouse_pos_ = cursor_pos;
 
   if (!IsWindowActive() ||
       !WindowContainsPoint(cursor_pos) ||
       (cursor_pos.y() >= GetPopupRect(true).bottom()) ||
       !idle_timeout_.IsRunning()) {
     // The cursor is offscreen, in the slide-out region, or idle.
     if (!initial_delay_.IsRunning()) {
       Hide();
     }
-  } else if ((cursor_pos.y() < kSlideInRegionHeightPx) ||
-             IsAnimating()) {
-    // The cursor is not idle, and either it's in the slide-in region or it's in
-    // the neutral region and we're sliding out.
+  } else if (cursor_pos.y() < kSlideInRegionHeightPx) {
+    if (CanMouseTriggerSlideIn())
+      Show();
+  } else if (IsAnimating()) {
+    // The cursor is not idle and its in the neutral region and we are sliding

[scheib, 2013/04/10 22:23:19]

it is == it's.

+    // in or out.
     Show();
   }
 }
 
 void FullscreenExitBubble::ToggleFullscreen() {
   browser_->fullscreen_controller()->
       ExitTabOrBrowserFullscreenToPreviousState();
 }
 
 void FullscreenExitBubble::Accept() {
@@ skipping 14 matching lines @@
 }
 
 string16 FullscreenExitBubble::GetAllowButtonText() const {
   return l10n_util::GetStringUTF16(IDS_FULLSCREEN_ALLOW);
 }
 
 string16 FullscreenExitBubble::GetInstructionText() const {
   return l10n_util::GetStringFUTF16(IDS_FULLSCREEN_PRESS_ESC_TO_EXIT,
       l10n_util::GetStringUTF16(IDS_APP_ESC_KEY));
 }