third_party/WebKit/Source/core/style/StyleGeneratedImage.h - Issue 1386413002: Added TODOs to StyleImage::create() to take PassRefPtrWillBeRawPtr

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/style/StyleGeneratedImage.h

Issue 1386413002: Added TODOs to StyleImage::create() to take PassRefPtrWillBeRawPtr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@make_styleresolverstate_styleImage_take_a_const_reference

Patch Set: Added comments to const_cast calls Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/paint/NinePieceImageGridTest.cpp ('k') | third_party/WebKit/Source/core/style/StyleGeneratedImage.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/style/StyleGeneratedImage.h

diff --git a/third_party/WebKit/Source/core/style/StyleGeneratedImage.h b/third_party/WebKit/Source/core/style/StyleGeneratedImage.h

index 4703939642e1ca18d91cbf3258a3574472b22265..ccac1ac4d6a08dd68fa7bd9c0c7f51cd50d66bc4 100644

--- a/third_party/WebKit/Source/core/style/StyleGeneratedImage.h

+++ b/third_party/WebKit/Source/core/style/StyleGeneratedImage.h

@@ -34,7 +34,8 @@ class CSSImageGeneratorValue;

class CORE_EXPORT StyleGeneratedImage final : public StyleImage {

public:

- static PassRefPtrWillBeRawPtr<StyleGeneratedImage> create(const CSSImageGeneratorValue& value)

+ // TODO(sashab): Make this take a PassRefPtrWillBeRawPtr<const CSSImageGeneratorValue>.

+ static PassRefPtrWillBeRawPtr<StyleGeneratedImage> create(PassRefPtrWillBeRawPtr<CSSImageGeneratorValue> value)

{

return adoptRefWillBeNoop(new StyleGeneratedImage(value));

}

@@ -58,7 +59,7 @@ public:

DECLARE_VIRTUAL_TRACE();

private:

- StyleGeneratedImage(const CSSImageGeneratorValue&);

+ StyleGeneratedImage(PassRefPtrWillBeRawPtr<CSSImageGeneratorValue>);

// TODO(sashab): Replace this with <const CSSImageGeneratorValue> once RefPtrWillBeMember<>

// supports const types.