third_party/WebKit/Source/core/style/StyleGeneratedImage.cpp - Issue 1386413002: Added TODOs to StyleImage::create() to take PassRefPtrWillBeRawPtr

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/style/StyleGeneratedImage.cpp

Issue 1386413002: Added TODOs to StyleImage::create() to take PassRefPtrWillBeRawPtr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@make_styleresolverstate_styleImage_take_a_const_reference

Patch Set: Added comments to const_cast calls Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/style/StyleGeneratedImage.h ('k') | third_party/WebKit/Source/core/style/StylePendingImage.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/style/StyleGeneratedImage.cpp

diff --git a/third_party/WebKit/Source/core/style/StyleGeneratedImage.cpp b/third_party/WebKit/Source/core/style/StyleGeneratedImage.cpp

index 690698217d05a56dab409131204a665914da7c81..74dfec8d699965b976ced7569a3a7e7a3561d20d 100644

--- a/third_party/WebKit/Source/core/style/StyleGeneratedImage.cpp

+++ b/third_party/WebKit/Source/core/style/StyleGeneratedImage.cpp

@@ -30,8 +30,8 @@

namespace blink {

-StyleGeneratedImage::StyleGeneratedImage(const CSSImageGeneratorValue& value)

- : m_imageGeneratorValue(const_cast<CSSImageGeneratorValue*>(&value))

+StyleGeneratedImage::StyleGeneratedImage(PassRefPtrWillBeRawPtr<CSSImageGeneratorValue> value)

+ : m_imageGeneratorValue(value)

, m_fixedSize(m_imageGeneratorValue->isFixedSize())

{

m_isGeneratedImage = true;