Move app launcher and chrome apps shortcut strings into the installer

chrome/installer/setup/uninstall.cc

Index: chrome/installer/setup/uninstall.cc
diff --git a/chrome/installer/setup/uninstall.cc b/chrome/installer/setup/uninstall.cc
index e86a867a5b08263144a847365d5a22ba84d734cc..88d7927b1f4489a8610114f99bd4e67d1c7fd970 100644
--- a/chrome/installer/setup/uninstall.cc
+++ b/chrome/installer/setup/uninstall.cc
@@ -353,8 +353,9 @@ void DeleteShortcuts(const InstallerState& installer_state,
   }
 
   VLOG(1) << "Deleting Start Menu shortcuts.";
-  if (!ShellUtil::RemoveShortcuts(ShellUtil::SHORTCUT_LOCATION_START_MENU, dist,
-                                  install_level, target_exe)) {
+  if (!ShellUtil::RemoveShortcuts(

[huangs, 2013/05/15 02:33:46]

How about SHORTCUT_LOCATION_START_MENU_CHROME_DIR and
SHORTCUT_LOCATION_START_MENU_CHROME_APPS_DIR?

[gab, 2013/05/15 21:26:38]

Yes, please add deletion of the SHORTCUT_LOCATION_START_MENU_CHROME_APPS_DIR as
well (or, even better, make a small CL after this one to do this and fix
http://crbug.com/238895; instead of making this CL even bigger...).

SHORTCUT_LOCATION_START_MENU_ROOT also needs to be purged of v1 apps shortcuts
(it never was...).

We are getting to a point where we have a lot of calls here and with huangs@'s
recent addition of BatchShortcutAction in ShellUtil, most the logic shifted away
from here.

I think this code can now simply iterate over all the ShortcutLocations and call
RemoveShortcuts on them (RemoveShortcuts knows which set of shortcut actions to
apply :), thanks Sam!).

But again, I'd keep that for another CL.

[calamity, 2013/08/27 07:59:35]

Done.

+      ShellUtil::SHORTCUT_LOCATION_START_MENU_CHROME_DIR, dist, install_level,
+      target_exe)) {
     LOG(WARNING) << "Failed to delete Start Menu shortcuts.";
   }