Move app launcher and chrome apps shortcut strings into the installer

chrome/installer/setup/uninstall.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 //
 // This file defines the methods useful for uninstalling Chrome.
 
 #include "chrome/installer/setup/uninstall.h"
 
 #include <windows.h>
 
@@ skipping 335 matching lines @@
     LOG(WARNING) << "Failed to delete Desktop shortcuts.";
   }
 
   VLOG(1) << "Deleting Quick Launch shortcuts.";
   if (!ShellUtil::RemoveShortcuts(ShellUtil::SHORTCUT_LOCATION_QUICK_LAUNCH,
                                   dist, install_level, target_exe)) {
     LOG(WARNING) << "Failed to delete Quick Launch shortcuts.";
   }
 
   VLOG(1) << "Deleting Start Menu shortcuts.";
-  if (!ShellUtil::RemoveShortcuts(ShellUtil::SHORTCUT_LOCATION_START_MENU, dist,
-                                  install_level, target_exe)) {
+  if (!ShellUtil::RemoveShortcuts(

[huangs, 2013/05/15 02:33:46]

How about SHORTCUT_LOCATION_START_MENU_CHROME_DIR and
SHORTCUT_LOCATION_START_MENU_CHROME_APPS_DIR?

[gab, 2013/05/15 21:26:38]

Yes, please add deletion of the SHORTCUT_LOCATION_START_MENU_CHROME_APPS_DIR as
well (or, even better, make a small CL after this one to do this and fix
http://crbug.com/238895; instead of making this CL even bigger...).

SHORTCUT_LOCATION_START_MENU_ROOT also needs to be purged of v1 apps shortcuts
(it never was...).

We are getting to a point where we have a lot of calls here and with huangs@'s
recent addition of BatchShortcutAction in ShellUtil, most the logic shifted away
from here.

I think this code can now simply iterate over all the ShortcutLocations and call
RemoveShortcuts on them (RemoveShortcuts knows which set of shortcut actions to
apply :), thanks Sam!).

But again, I'd keep that for another CL.

[calamity, 2013/08/27 07:59:35]

Done.

+      ShellUtil::SHORTCUT_LOCATION_START_MENU_CHROME_DIR, dist, install_level,
+      target_exe)) {
     LOG(WARNING) << "Failed to delete Start Menu shortcuts.";
   }
 
   // Unpin all pinned-to-taskbar shortcuts that point to |chrome_exe|.
   if (!ShellUtil::RemoveShortcuts(ShellUtil::SHORTCUT_LOCATION_TASKBAR_PINS,
                                   dist, ShellUtil::CURRENT_USER, target_exe)) {
     LOG(WARNING) << "Failed to unpin taskbar shortcuts at user-level.";
   }
 
   // Delete the folder of secondary tiles from the start screen for |dist|.
@@ skipping 1062 matching lines @@
     // deletion unconditionally. If they are not empty, the session manager
     // will not delete them on reboot.
     ScheduleParentAndGrandparentForDeletion(target_path);
   } else if (DeleteApplicationProductAndVendorDirectories(target_path) ==
              installer::DELETE_FAILED) {
     *uninstall_status = installer::UNINSTALL_FAILED;
   }
 }
 
 }  // namespace installer