Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(355)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1386343003: Revert "dart2js cps: Maintain parent pointers instead of recomputing them." (Closed)

Created:
5 years, 2 months ago by asgerf
Modified:
5 years, 2 months ago
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Revert "dart2js cps: Maintain parent pointers instead of recomputing them." This reverts commit 6cc9b435354ea4fe3796437e3cc7091f6a11de19. BUG= Committed: https://github.com/dart-lang/sdk/commit/77eb3fb60f28fe86a446f0703da3dc28a3211e41

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+349 lines, -417 lines) Patch
M pkg/compiler/lib/src/cps_ir/cps_fragment.dart View 2 chunks +0 lines, -16 lines 0 comments Download
M pkg/compiler/lib/src/cps_ir/cps_ir_integrity.dart View 3 chunks +5 lines, -50 lines 0 comments Download
M pkg/compiler/lib/src/cps_ir/cps_ir_nodes.dart View 55 chunks +25 lines, -250 lines 0 comments Download
M pkg/compiler/lib/src/cps_ir/insert_refinements.dart View 4 chunks +3 lines, -8 lines 0 comments Download
M pkg/compiler/lib/src/cps_ir/mutable_ssa.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/cps_ir/optimizers.dart View 1 chunk +1 line, -2 lines 0 comments Download
D pkg/compiler/lib/src/cps_ir/parent_visitor.dart View 1 chunk +0 lines, -43 lines 0 comments Download
M pkg/compiler/lib/src/cps_ir/redundant_join.dart View 3 chunks +3 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/cps_ir/redundant_phi.dart View 1 chunk +4 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/cps_ir/remove_refinements.dart View 1 chunk +3 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/cps_ir/scalar_replacement.dart View 4 chunks +4 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/cps_ir/share_interceptors.dart View 2 chunks +1 line, -2 lines 0 comments Download
M pkg/compiler/lib/src/cps_ir/shrinking_reductions.dart View 8 chunks +240 lines, -8 lines 0 comments Download
M pkg/compiler/lib/src/cps_ir/type_propagation.dart View 6 chunks +9 lines, -4 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/codegen/task.dart View 3 chunks +3 lines, -4 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/codegen/unsugar.dart View 10 chunks +46 lines, -20 lines 0 comments Download
M tests/compiler/dart2js/js_backend_cps_ir_source_information_test.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (1 generated)
asgerf
Once again, yet another way to run the analyzer has appeared.
5 years, 2 months ago (2015-10-12 14:50:22 UTC) #2
asgerf
5 years, 2 months ago (2015-10-12 14:50:43 UTC) #3
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
77eb3fb60f28fe86a446f0703da3dc28a3211e41 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698