Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(363)

Unified Diff: pkg/compiler/lib/src/cps_ir/share_interceptors.dart

Issue 1386343003: Revert "dart2js cps: Maintain parent pointers instead of recomputing them." (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/compiler/lib/src/cps_ir/share_interceptors.dart
diff --git a/pkg/compiler/lib/src/cps_ir/share_interceptors.dart b/pkg/compiler/lib/src/cps_ir/share_interceptors.dart
index 3706725e3d102a8c63b652ec7fe196761d9e435c..5ae912e81d0baa0b4698bff409c298eb1ecb024b 100644
--- a/pkg/compiler/lib/src/cps_ir/share_interceptors.dart
+++ b/pkg/compiler/lib/src/cps_ir/share_interceptors.dart
@@ -15,7 +15,7 @@ import '../constants/values.dart';
///- pull interceptors out of loops
///- replace interceptors with constants
///- share interceptors when one is in scope of the other
-class ShareInterceptors extends TrampolineRecursiveVisitor implements Pass {
+class ShareInterceptors extends RecursiveVisitor implements Pass {
String get passName => 'Share interceptors';
/// The innermost loop containing a given primitive.
@@ -115,7 +115,6 @@ class ShareInterceptors extends TrampolineRecursiveVisitor implements Pass {
// The interceptor could not be shared. Replace it with a constant.
Constant constantPrim = new Constant(constant);
node.primitive = constantPrim;
- constantPrim.parent = node;
constantPrim.hint = interceptor.hint;
constantPrim.type = interceptor.type;
constantPrim.substituteFor(interceptor);
« no previous file with comments | « pkg/compiler/lib/src/cps_ir/scalar_replacement.dart ('k') | pkg/compiler/lib/src/cps_ir/shrinking_reductions.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698