sdk/lib/web_sql/dart2js/web_sql_dart2js.dart - Issue 13863012: Refactor List.setRange function.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sdk/lib/web_sql/dart2js/web_sql_dart2js.dart

Issue 13863012: Refactor List.setRange function. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Addressed comments. Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: sdk/lib/web_sql/dart2js/web_sql_dart2js.dart

diff --git a/sdk/lib/web_sql/dart2js/web_sql_dart2js.dart b/sdk/lib/web_sql/dart2js/web_sql_dart2js.dart

index ea2ea489264076ba2482e5c560f003b8ecd054d9..9c55643fd926cd6d3f177c7dd71eb075011c60a8 100644

--- a/sdk/lib/web_sql/dart2js/web_sql_dart2js.dart

+++ b/sdk/lib/web_sql/dart2js/web_sql_dart2js.dart

@@ -363,7 +363,7 @@ class SqlResultSetRowList implements JavaScriptIndexingBehavior, List<Map> nativ

throw new UnsupportedError("Cannot remove from immutable List.");

}

- void setRange(int start, int rangeLength, List<Map> from, [int startFrom]) {

+ void setRange(int start, int end, Iterable<Map> iterable, [int skipCount]) {

throw new UnsupportedError("Cannot setRange on immutable List.");

}

« no previous file with comments | « sdk/lib/utf/utf8.dart ('k') | sdk/lib/web_sql/dartium/web_sql_dartium.dart » ('j') | no next file with comments »