sdk/lib/utf/utf8.dart - Issue 13863012: Refactor List.setRange function.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sdk/lib/utf/utf8.dart

Issue 13863012: Refactor List.setRange function. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Addressed comments. Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: sdk/lib/utf/utf8.dart

diff --git a/sdk/lib/utf/utf8.dart b/sdk/lib/utf/utf8.dart

index 893cf0fe39b7a7e4fe1695b90cf7791241a1fb0b..a218fc198434a895548b34d73691e04a566db6a3 100644

--- a/sdk/lib/utf/utf8.dart

+++ b/sdk/lib/utf/utf8.dart

@@ -90,7 +90,7 @@ List<int> codepointsToUtf8(

int insertAt = 0;

for (int value in source) {

if (value < 0 || value > UNICODE_VALID_RANGE_MAX) {

- encoded.setRange(insertAt, 3, [0xef, 0xbf, 0xbd]);

+ encoded.setRange(insertAt, insertAt + 3, [0xef, 0xbf, 0xbd]);

insertAt += 3;

} else if (value <= _UTF8_ONE_BYTE_MAX) {

encoded[insertAt] = value;

« no previous file with comments | « sdk/lib/svg/dartium/svg_dartium.dart ('k') | sdk/lib/web_sql/dart2js/web_sql_dart2js.dart » ('j') | no next file with comments »