sdk/lib/_collection_dev/list.dart - Issue 13863012: Refactor List.setRange function.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sdk/lib/_collection_dev/list.dart

Issue 13863012: Refactor List.setRange function. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Addressed comments. Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: sdk/lib/_collection_dev/list.dart

diff --git a/sdk/lib/_collection_dev/list.dart b/sdk/lib/_collection_dev/list.dart

index 3ab841d71ba273d25b4fa41b0f79f06beeb08b3e..6d955aef6a8d54477baac5d714820f3affbf2dbd 100644

--- a/sdk/lib/_collection_dev/list.dart

+++ b/sdk/lib/_collection_dev/list.dart

@@ -160,7 +160,7 @@ abstract class UnmodifiableListMixin<E> {

"Cannot remove from an unmodifiable list");

}

- void setRange(int start, int length, List<E> from, [int startFrom]) {

+ void setRange(int start, int end, Iterable<E> iterable, [int skipCount = 0]) {

throw new UnsupportedError(

"Cannot modify an unmodifiable list");

}