Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(542)

Unified Diff: sdk/lib/_internal/compiler/implementation/lib/js_array.dart

Issue 13863012: Refactor List.setRange function. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Addressed comments. Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sdk/lib/_collection_dev/list.dart ('k') | sdk/lib/collection/list.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sdk/lib/_internal/compiler/implementation/lib/js_array.dart
diff --git a/sdk/lib/_internal/compiler/implementation/lib/js_array.dart b/sdk/lib/_internal/compiler/implementation/lib/js_array.dart
index 7a57e31d26ac0e8857c97f20964969f0ab8b4787..22f50182b060b21e4d162ad47d3f818b340c3dd4 100644
--- a/sdk/lib/_internal/compiler/implementation/lib/js_array.dart
+++ b/sdk/lib/_internal/compiler/implementation/lib/js_array.dart
@@ -229,9 +229,9 @@ class JSArray<E> extends Interceptor implements List<E>, JSIndexable {
this.length = receiverLength - length;
}
- void setRange(int start, int length, List<E> from, [int startFrom = 0]) {
+ void setRange(int start, int end, Iterable<E> iterable, [int skipCount = 0]) {
checkMutable(this, 'set range');
- IterableMixinWorkaround.setRangeList(this, start, length, from, startFrom);
+ IterableMixinWorkaround.setRangeList(this, start, end, iterable, skipCount);
}
bool any(bool f(E element)) => IterableMixinWorkaround.any(this, f);
« no previous file with comments | « sdk/lib/_collection_dev/list.dart ('k') | sdk/lib/collection/list.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698