GTTF: Make debug symbol "resolution" work even after binaries are moved.

GTTF: Make debug symbol "resolution" work even after binaries are moved.

This happens e.g. between the builder and tester bots.

This is a resubmit of https://codereview.chromium.org/12557003 ,
but with the new logic disabled on Windows XP because of mysterious
hangs.

BUG=168411
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=193655

[Paweł Hajdan Jr., 2013-04-10 18:54:53]

Note this is a resubmit of an earlier change (see the description).

[cpu_(ooo_6.6-7.5), 2013-04-10 23:19:26]

lgtm

https://codereview.chromium.org/13863008/diff/1/base/debug/stack_trace_win.cc
File base/debug/stack_trace_win.cc (right):

https://codereview.chromium.org/13863008/diff/1/base/debug/stack_trace_win.cc...
base/debug/stack_trace_win.cc:169: DLOG(WARNING) << "PathService::Get(FILE_EXE)
failed.";
I would seem to me that we should avoid calling dlog , or any log here since
this function can be called inside a log statement.. is that so?

[Paweł Hajdan Jr., 2013-04-10 23:50:19]

https://codereview.chromium.org/13863008/diff/1/base/debug/stack_trace_win.cc
File base/debug/stack_trace_win.cc (right):

https://codereview.chromium.org/13863008/diff/1/base/debug/stack_trace_win.cc...
base/debug/stack_trace_win.cc:169: DLOG(WARNING) << "PathService::Get(FILE_EXE)
failed.";
On 2013/04/10 23:19:26, cpu wrote:
> I would seem to me that we should avoid calling dlog , or any log here since
> this function can be called inside a log statement.. is that so?

There was a DLOG here already and I think it's useful to have some kind of
indication of failure here.

I've tried to produce a pathological situation of calling this on a line that
also has LOG, but it's fine. I think it's evaluated before calling expansion of
LOG, so I wouldn't expect any re-entrancy problems here.

[jar (doing other things), 2013-04-10 23:52:17]

Rubber stamp of Carlos' LGTM

[Paweł Hajdan Jr., 2013-04-11 16:00:04]

Committed patchset #1 manually as r193655 (presubmit successful).