Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(271)

Issue 13863008: GTTF: Make debug symbol "resolution" work even after binaries are moved. (Closed)

Created:
7 years, 8 months ago by Paweł Hajdan Jr.
Modified:
7 years, 8 months ago
CC:
chromium-reviews, erikwright+watch_chromium.org
Visibility:
Public.

Description

GTTF: Make debug symbol "resolution" work even after binaries are moved. This happens e.g. between the builder and tester bots. This is a resubmit of https://codereview.chromium.org/12557003 , but with the new logic disabled on Windows XP because of mysterious hangs. BUG=168411 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=193655

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -3 lines) Patch
M base/debug/stack_trace_win.cc View 3 chunks +39 lines, -3 lines 2 comments Download

Messages

Total messages: 5 (0 generated)
Paweł Hajdan Jr.
Note this is a resubmit of an earlier change (see the description).
7 years, 8 months ago (2013-04-10 18:54:53 UTC) #1
cpu_(ooo_6.6-7.5)
lgtm https://codereview.chromium.org/13863008/diff/1/base/debug/stack_trace_win.cc File base/debug/stack_trace_win.cc (right): https://codereview.chromium.org/13863008/diff/1/base/debug/stack_trace_win.cc#newcode169 base/debug/stack_trace_win.cc:169: DLOG(WARNING) << "PathService::Get(FILE_EXE) failed."; I would seem to ...
7 years, 8 months ago (2013-04-10 23:19:26 UTC) #2
Paweł Hajdan Jr.
https://codereview.chromium.org/13863008/diff/1/base/debug/stack_trace_win.cc File base/debug/stack_trace_win.cc (right): https://codereview.chromium.org/13863008/diff/1/base/debug/stack_trace_win.cc#newcode169 base/debug/stack_trace_win.cc:169: DLOG(WARNING) << "PathService::Get(FILE_EXE) failed."; On 2013/04/10 23:19:26, cpu wrote: ...
7 years, 8 months ago (2013-04-10 23:50:19 UTC) #3
jar (doing other things)
Rubber stamp of Carlos' LGTM
7 years, 8 months ago (2013-04-10 23:52:17 UTC) #4
Paweł Hajdan Jr.
7 years, 8 months ago (2013-04-11 16:00:04 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 manually as r193655 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698