Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1735)

Issue 12557003: GTTF: Make debug symbol "resolution" work even after binaries are moved. (Closed)

Created:
7 years, 9 months ago by Paweł Hajdan Jr.
Modified:
7 years, 9 months ago
CC:
chromium-reviews, erikwright+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

GTTF: Make debug symbol "resolution" work even after binaries are moved. This happens e.g. between the builder and tester bots. BUG=168411 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=187002

Patch Set 1 #

Total comments: 1

Patch Set 2 : sizeof -> arraysize #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -3 lines) Patch
M base/debug/stack_trace_win.cc View 1 3 chunks +34 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
Paweł Hajdan Jr.
Carlos, could you take a look if this makes sense? I'm sending to you first ...
7 years, 9 months ago (2013-03-07 01:49:09 UTC) #1
cpu_(ooo_6.6-7.5)
https://codereview.chromium.org/12557003/diff/1/base/debug/stack_trace_win.cc File base/debug/stack_trace_win.cc (right): https://codereview.chromium.org/12557003/diff/1/base/debug/stack_trace_win.cc#newcode154 base/debug/stack_trace_win.cc:154: sizeof(symbols_path))) { last parameter looks incorrect, I don't think ...
7 years, 9 months ago (2013-03-07 20:31:49 UTC) #2
cpu_(ooo_6.6-7.5)
other than that lgtm
7 years, 9 months ago (2013-03-07 20:36:17 UTC) #3
Paweł Hajdan Jr.
Jim, could you do a base OWNERS review?
7 years, 9 months ago (2013-03-07 21:53:56 UTC) #4
jar (doing other things)
lgtm
7 years, 9 months ago (2013-03-08 00:59:06 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/phajdan.jr@chromium.org/12557003/6001
7 years, 9 months ago (2013-03-08 01:40:48 UTC) #6
commit-bot: I haz the power
Presubmit check for 12557003-6001 failed and returned exit status 1. INFO:root:Found 1 file(s). Running presubmit ...
7 years, 9 months ago (2013-03-08 01:40:50 UTC) #7
Paweł Hajdan Jr.
7 years, 9 months ago (2013-03-08 18:41:49 UTC) #8
Message was sent while issue was closed.
Committed patchset #2 manually as r187002 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698