Issue 13861028: Expose MutationRecord on DOMWindow

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 13861028: Expose MutationRecord on DOMWindow (Closed)

Created:
7 years, 8 months ago by adamk

Modified:
7 years, 8 months ago

Reviewers:
eseidel, arv (Not doing code reviews), ojan

CC:
blink-reviews, arv (Not doing code reviews), rafaelw

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

Expose MutationRecord on DOMWindow MutationRecord is not constructable, but exposing it matches the spec, Gecko's implementation, and provides the ability to do instanceof checks. BUG=229416 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=147975

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+31 lines, -0 lines)			Patch
A	LayoutTests/fast/dom/MutationObserver/mutation-record-constructor.html	View	1 chunk	+17 lines, -0 lines	0 comments	Download
A	LayoutTests/fast/dom/MutationObserver/mutation-record-constructor-expected.txt	View	1 chunk	+13 lines, -0 lines	0 comments	Download
M	Source/WebCore/page/DOMWindow.idl	View	1 chunk	+1 line, -0 lines	0 comments	Download

Total messages: 5 (0 generated)

eseidel

This feels like a trivial change. If IE/FF agree with this than, LGTM.

7 years, 8 months ago (2013-04-09 21:01:14 UTC) #3

arv (Not doing code reviews)

LGTM IE11 implements this based on the leaked WinBlue builds but it is a bit ...

7 years, 8 months ago (2013-04-09 21:26:11 UTC) #4

adamk

7 years, 8 months ago (2013-04-09 21:45:15 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 manually as r147975 (presubmit successful).