Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(22)

Issue 13861028: Expose MutationRecord on DOMWindow (Closed)

Created:
6 years, 4 months ago by adamk
Modified:
6 years, 4 months ago
CC:
blink-reviews, arv (Not doing code reviews), rafaelw
Visibility:
Public.

Description

Expose MutationRecord on DOMWindow MutationRecord is not constructable, but exposing it matches the spec, Gecko's implementation, and provides the ability to do instanceof checks. BUG=229416 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=147975

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -0 lines) Patch
A LayoutTests/fast/dom/MutationObserver/mutation-record-constructor.html View 1 chunk +17 lines, -0 lines 0 comments Download
A LayoutTests/fast/dom/MutationObserver/mutation-record-constructor-expected.txt View 1 chunk +13 lines, -0 lines 0 comments Download
M Source/WebCore/page/DOMWindow.idl View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
adamk
6 years, 4 months ago (2013-04-09 20:54:22 UTC) #1
adamk
Should this change go through some API review?
6 years, 4 months ago (2013-04-09 20:54:42 UTC) #2
eseidel
This feels like a trivial change. If IE/FF agree with this than, LGTM.
6 years, 4 months ago (2013-04-09 21:01:14 UTC) #3
arv (Not doing code reviews)
LGTM IE11 implements this based on the leaked WinBlue builds but it is a bit ...
6 years, 4 months ago (2013-04-09 21:26:11 UTC) #4
adamk
6 years, 4 months ago (2013-04-09 21:45:15 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 manually as r147975 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698