Issue 1386053002: Merge to XFA: CJS_Timer should observe CJS_Runtime destruction.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1386053002: Merge to XFA: CJS_Timer should observe CJS_Runtime destruction. (Closed)

Created:
5 years, 2 months ago by Lei Zhang

Modified:
5 years, 2 months ago

Reviewers:
Tom Sepez

CC:
pdfium-reviews_googlegroups.com

Base URL:
https://pdfium.googlesource.com/pdfium.git@xfa

Target Ref:
refs/heads/xfa

Visibility:
Public.

Merge to XFA: CJS_Timer should observe CJS_Runtime destruction. Also remove dead CJS_EmbedObj::{Begin,End}Timer code. BUG=539107 R=tsepez@chromium.org Review URL: https://codereview.chromium.org/1384883002 . (cherry picked from commit 794c9b67d3d519342aa7e15052766f7d4a99f551) Committed: https://pdfium.googlesource.com/pdfium/+/2d5a0e173f3bb8335cf302f1194305c2f9e65bed

Created: 5 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+92 lines, -82 lines)			Patch
M	fpdfsdk/include/javascript/JS_Object.h	View	4 chunks	+23 lines, -40 lines	0 comments	Download
M	fpdfsdk/include/javascript/JS_Runtime.h	View	3 chunks	+12 lines, -0 lines	0 comments	Download
M	fpdfsdk/src/javascript/JS_Object.cpp	View	4 chunks	+34 lines, -24 lines	0 comments	Download
M	fpdfsdk/src/javascript/JS_Runtime.cpp	View	3 chunks	+13 lines, -1 line	0 comments	Download
M	fpdfsdk/src/javascript/app.cpp	View	3 chunks	+10 lines, -17 lines	0 comments	Download

Total messages: 2 (0 generated)

Lei Zhang

TBR, merge conflicts in JS_Runtime.*, but easy to resolve.

5 years, 2 months ago (2015-10-05 23:59:58 UTC) #1

Lei Zhang

5 years, 2 months ago (2015-10-06 00:00:07 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
2d5a0e173f3bb8335cf302f1194305c2f9e65bed (presubmit successful).