Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(859)

Side by Side Diff: fpdfsdk/src/javascript/JS_Runtime.cpp

Issue 1386053002: Merge to XFA: CJS_Timer should observe CJS_Runtime destruction. (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@xfa
Patch Set: Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « fpdfsdk/src/javascript/JS_Object.cpp ('k') | fpdfsdk/src/javascript/app.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 PDFium Authors. All rights reserved. 1 // Copyright 2014 PDFium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com 5 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
6 6
7 #include "../../include/javascript/IJavaScript.h" 7 #include "../../include/javascript/IJavaScript.h"
8 #include "../../include/javascript/JS_EventHandler.h" 8 #include "../../include/javascript/JS_EventHandler.h"
9 #include "../../include/javascript/JS_Runtime.h" 9 #include "../../include/javascript/JS_Runtime.h"
10 #include "../../include/javascript/JS_Context.h" 10 #include "../../include/javascript/JS_Context.h"
11 #include "../../include/javascript/JS_Define.h" 11 #include "../../include/javascript/JS_Define.h"
12 #include "../../include/javascript/JS_Object.h" 12 #include "../../include/javascript/JS_Object.h"
13 #include "../../include/javascript/JS_Value.h" 13 #include "../../include/javascript/JS_Value.h"
14 #include "../../include/javascript/Document.h"
15 #include "../../include/javascript/app.h" 14 #include "../../include/javascript/app.h"
16 #include "../../include/javascript/color.h" 15 #include "../../include/javascript/color.h"
17 #include "../../include/javascript/Consts.h" 16 #include "../../include/javascript/Consts.h"
18 #include "../../include/javascript/Document.h" 17 #include "../../include/javascript/Document.h"
19 #include "../../include/javascript/event.h" 18 #include "../../include/javascript/event.h"
20 #include "../../include/javascript/Field.h" 19 #include "../../include/javascript/Field.h"
21 #include "../../include/javascript/Icon.h" 20 #include "../../include/javascript/Icon.h"
22 #include "../../include/javascript/PublicMethods.h" 21 #include "../../include/javascript/PublicMethods.h"
23 #include "../../include/javascript/report.h" 22 #include "../../include/javascript/report.h"
24 #include "../../include/javascript/util.h" 23 #include "../../include/javascript/util.h"
(...skipping 45 matching lines...) Expand 10 before | Expand all | Expand 10 after
70 FXJS_Initialize(embedderDataSlot); 69 FXJS_Initialize(embedderDataSlot);
71 DefineJSObjects(); 70 DefineJSObjects();
72 CPDFXFA_App::GetInstance()->SetJavaScriptInitialized(TRUE); 71 CPDFXFA_App::GetInstance()->SetJavaScriptInitialized(TRUE);
73 72
74 CJS_Context* pContext = (CJS_Context*)NewContext(); 73 CJS_Context* pContext = (CJS_Context*)NewContext();
75 FXJS_InitializeRuntime(GetIsolate(), this, pContext, m_context); 74 FXJS_InitializeRuntime(GetIsolate(), this, pContext, m_context);
76 ReleaseContext(pContext); 75 ReleaseContext(pContext);
77 } 76 }
78 77
79 CJS_Runtime::~CJS_Runtime() { 78 CJS_Runtime::~CJS_Runtime() {
79 for (auto* obs : m_observers)
80 obs->OnDestroyed();
81
80 int size = m_ContextArray.GetSize(); 82 int size = m_ContextArray.GetSize();
81 for (int i = 0; i < size; i++) 83 for (int i = 0; i < size; i++)
82 delete m_ContextArray.GetAt(i); 84 delete m_ContextArray.GetAt(i);
83 85
84 m_ContextArray.RemoveAll(); 86 m_ContextArray.RemoveAll();
85 87
86 m_pApp = NULL; 88 m_pApp = NULL;
87 m_pDocument = NULL; 89 m_pDocument = NULL;
88 m_context.Reset(); 90 m_context.Reset();
89 91
(...skipping 159 matching lines...) Expand 10 before | Expand all | Expand 10 after
249 // v8::Local<v8::Context>::New(GetIsolate(), m_context); 251 // v8::Local<v8::Context>::New(GetIsolate(), m_context);
250 v8::Local<v8::Value> propvalue = v8::Local<v8::Value>::New( 252 v8::Local<v8::Value> propvalue = v8::Local<v8::Value>::New(
251 GetIsolate(), ((CFXJSE_Value*)hValue)->DirectGetValue()); 253 GetIsolate(), ((CFXJSE_Value*)hValue)->DirectGetValue());
252 context->Global()->Set( 254 context->Global()->Set(
253 v8::String::NewFromUtf8(pIsolate, name, v8::String::kNormalString, 255 v8::String::NewFromUtf8(pIsolate, name, v8::String::kNormalString,
254 utf8Name.GetLength()), 256 utf8Name.GetLength()),
255 propvalue); 257 propvalue);
256 258
257 return TRUE; 259 return TRUE;
258 } 260 }
261
262 void CJS_Runtime::AddObserver(Observer* observer) {
263 ASSERT(m_observers.find(observer) == m_observers.end());
264 m_observers.insert(observer);
265 }
266
267 void CJS_Runtime::RemoveObserver(Observer* observer) {
268 ASSERT(m_observers.find(observer) != m_observers.end());
269 m_observers.erase(observer);
270 }
OLDNEW
« no previous file with comments | « fpdfsdk/src/javascript/JS_Object.cpp ('k') | fpdfsdk/src/javascript/app.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698