Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(368)

Unified Diff: components/dom_distiller/content/browser/dom_distiller_viewer_source.cc

Issue 1386043002: Open distiller UI setting through JavaScript (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Comment nits Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/dom_distiller/content/browser/dom_distiller_viewer_source.cc
diff --git a/components/dom_distiller/content/browser/dom_distiller_viewer_source.cc b/components/dom_distiller/content/browser/dom_distiller_viewer_source.cc
index 4a8e424b41f59af7715947a7913e675be11eb1ab..65a327dc8a3567638d252dba744d3b44c58cb5aa 100644
--- a/components/dom_distiller/content/browser/dom_distiller_viewer_source.cc
+++ b/components/dom_distiller/content/browser/dom_distiller_viewer_source.cc
@@ -16,7 +16,7 @@
#include "base/strings/utf_string_conversions.h"
#include "components/dom_distiller/content/browser/distiller_javascript_service_impl.h"
#include "components/dom_distiller/content/browser/distiller_javascript_utils.h"
-#include "components/dom_distiller/content/browser/external_feedback_reporter.h"
+#include "components/dom_distiller/content/browser/distiller_ui_handle.h"
#include "components/dom_distiller/content/common/distiller_page_notifier_service.mojom.h"
#include "components/dom_distiller/core/distilled_page_prefs.h"
#include "components/dom_distiller/core/dom_distiller_request_view_base.h"
@@ -168,10 +168,10 @@ void DomDistillerViewerSource::RequestViewerHandle::DidFinishLoad(
DomDistillerViewerSource::DomDistillerViewerSource(
DomDistillerServiceInterface* dom_distiller_service,
const std::string& scheme,
- scoped_ptr<ExternalFeedbackReporter> external_reporter)
+ scoped_ptr<DistillerUIHandle> ui_handle)
: scheme_(scheme),
dom_distiller_service_(dom_distiller_service),
- external_feedback_reporter_(external_reporter.Pass()) {
+ distiller_ui_handle_(ui_handle.Pass()) {
}
DomDistillerViewerSource::~DomDistillerViewerSource() {
@@ -232,7 +232,7 @@ void DomDistillerViewerSource::StartDataRequest(
render_frame_host->GetServiceRegistry()->AddService(
base::Bind(&CreateDistillerJavaScriptService,
render_frame_host,
- external_feedback_reporter_.get()));
+ distiller_ui_handle_.get()));
// Tell the renderer that this is currently a distilled page.
DistillerPageNotifierServicePtr page_notifier_service;

Powered by Google App Engine
This is Rietveld 408576698