Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(655)

Unified Diff: components/dom_distiller/content/browser/dom_distiller_viewer_source.h

Issue 1386043002: Open distiller UI setting through JavaScript (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Comment nits Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/dom_distiller/content/browser/dom_distiller_viewer_source.h
diff --git a/components/dom_distiller/content/browser/dom_distiller_viewer_source.h b/components/dom_distiller/content/browser/dom_distiller_viewer_source.h
index 9cf77d72bff1a903338fce2c43c247c64e65c1af..fbd3d5be11a1bb9de49e4303a470d3f130729104 100644
--- a/components/dom_distiller/content/browser/dom_distiller_viewer_source.h
+++ b/components/dom_distiller/content/browser/dom_distiller_viewer_source.h
@@ -10,7 +10,7 @@
#include "base/basictypes.h"
#include "base/compiler_specific.h"
#include "base/memory/scoped_ptr.h"
-#include "components/dom_distiller/content/browser/external_feedback_reporter.h"
+#include "components/dom_distiller/content/browser/distiller_ui_handle.h"
#include "content/public/browser/url_data_source.h"
namespace dom_distiller {
@@ -26,7 +26,7 @@ class DomDistillerViewerSource : public content::URLDataSource {
DomDistillerViewerSource(
DomDistillerServiceInterface* dom_distiller_service,
const std::string& scheme,
- scoped_ptr<ExternalFeedbackReporter> external_reporter);
+ scoped_ptr<DistillerUIHandle> ui_handle);
~DomDistillerViewerSource() override;
class RequestViewerHandle;
@@ -55,8 +55,9 @@ class DomDistillerViewerSource : public content::URLDataSource {
// the list of articles.
DomDistillerServiceInterface* dom_distiller_service_;
- // A means for starting/opening an external service for feedback reporting.
- scoped_ptr<ExternalFeedbackReporter> external_feedback_reporter_;
+ // An object for accessing chrome-specific UI controls including external
+ // feedback and opening the distiller settings.
+ scoped_ptr<DistillerUIHandle> distiller_ui_handle_;
DISALLOW_COPY_AND_ASSIGN(DomDistillerViewerSource);
};

Powered by Google App Engine
This is Rietveld 408576698