Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4894)

Unified Diff: components/dom_distiller/content/browser/distiller_ui_handle.h

Issue 1386043002: Open distiller UI setting through JavaScript (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Comment nits Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/dom_distiller/content/browser/distiller_ui_handle.h
diff --git a/components/dom_distiller/content/browser/external_feedback_reporter.h b/components/dom_distiller/content/browser/distiller_ui_handle.h
similarity index 59%
copy from components/dom_distiller/content/browser/external_feedback_reporter.h
copy to components/dom_distiller/content/browser/distiller_ui_handle.h
index 90586c3600fca4b6b5982e17a16c815105310983..7908a58489ae565db68a85c27c4d1277ca373a20 100644
--- a/components/dom_distiller/content/browser/external_feedback_reporter.h
+++ b/components/dom_distiller/content/browser/distiller_ui_handle.h
@@ -2,8 +2,8 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
-#ifndef COMPONENTS_DOM_DISTILLER_CONTENT_BROWSER_EXTERNAL_FEEDBACK_REPORTER_H_
-#define COMPONENTS_DOM_DISTILLER_CONTENT_BROWSER_EXTERNAL_FEEDBACK_REPORTER_H_
+#ifndef COMPONENTS_DOM_DISTILLER_CONTENT_BROWSER_DISTILLER_UI_HANDLE_H_
+#define COMPONENTS_DOM_DISTILLER_CONTENT_BROWSER_DISTILLER_UI_HANDLE_H_
#include "base/macros.h"
#include "content/public/browser/web_contents.h"
@@ -13,20 +13,23 @@ namespace dom_distiller {
// ExternalFeedbackReporter handles reporting distillation quality through an
// external source.
-class ExternalFeedbackReporter {
+class DistillerUIHandle {
public:
- ExternalFeedbackReporter() {}
- virtual ~ExternalFeedbackReporter() {}
+ DistillerUIHandle() {}
+ virtual ~DistillerUIHandle() {}
// Start an external form to record user feedback.
virtual void ReportExternalFeedback(content::WebContents* web_contents,
const GURL& url,
const bool good) = 0;
+ // Open the UI settings for dom distiller.
+ virtual void OpenSettings(content::WebContents* web_contents) = 0;
+
private:
- DISALLOW_COPY_AND_ASSIGN(ExternalFeedbackReporter);
+ DISALLOW_COPY_AND_ASSIGN(DistillerUIHandle);
};
} // namespace dom_distiller
-#endif // COMPONENTS_DOM_DISTILLER_CONTENT_BROWSER_EXTERNAL_FEEDBACK_REPORTER_H_
+#endif // COMPONENTS_DOM_DISTILLER_CONTENT_BROWSER_DISTILLER_UI_HANDLE_H_

Powered by Google App Engine
This is Rietveld 408576698