Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(62)

Unified Diff: components/dom_distiller/content/browser/distiller_javascript_service_impl.h

Issue 1386043002: Open distiller UI setting through JavaScript (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Add missing file Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/dom_distiller/content/browser/distiller_javascript_service_impl.h
diff --git a/components/dom_distiller/content/browser/distiller_javascript_service_impl.h b/components/dom_distiller/content/browser/distiller_javascript_service_impl.h
index fd58892eb411d7ea2e3c317e3dc3bd711213588c..d1ffe1018b09918c06db6a4b6cfec4446b10a6cc 100644
--- a/components/dom_distiller/content/browser/distiller_javascript_service_impl.h
+++ b/components/dom_distiller/content/browser/distiller_javascript_service_impl.h
@@ -5,7 +5,7 @@
#ifndef COMPONENTS_DOM_DISTILLER_CONTENT_BROWSER_DISTILLER_JAVASCRIPT_SERVICE_IMPL_H_
#define COMPONENTS_DOM_DISTILLER_CONTENT_BROWSER_DISTILLER_JAVASCRIPT_SERVICE_IMPL_H_
-#include "components/dom_distiller/content/browser/external_feedback_reporter.h"
+#include "components/dom_distiller/content/browser/distiller_ui_handle.h"
#include "components/dom_distiller/content/common/distiller_javascript_service.mojom.h"
#include "third_party/mojo/src/mojo/public/cpp/bindings/string.h"
#include "third_party/mojo/src/mojo/public/cpp/bindings/strong_binding.h"
@@ -17,7 +17,7 @@ class DistillerJavaScriptServiceImpl : public DistillerJavaScriptService {
public:
DistillerJavaScriptServiceImpl(
content::RenderFrameHost* render_frame_host,
- ExternalFeedbackReporter* external_feedback_reporter,
+ DistillerUIHandle* distiller_ui_handle,
mojo::InterfaceRequest<DistillerJavaScriptService> request);
~DistillerJavaScriptServiceImpl() override;
@@ -33,16 +33,19 @@ class DistillerJavaScriptServiceImpl : public DistillerJavaScriptService {
// Make a call into Android to close the overlay panel containing reader mode.
void HandleDistillerClosePanelCall() override;
+ // Show the Android view containing Reader Mode settings.
+ void HandleDistillerOpenSettingsCall() override;
+
private:
mojo::StrongBinding<DistillerJavaScriptService> binding_;
content::RenderFrameHost* render_frame_host_;
- ExternalFeedbackReporter* external_feedback_reporter_;
+ DistillerUIHandle* distiller_ui_handle_;
};
// static
void CreateDistillerJavaScriptService(
content::RenderFrameHost* render_frame_host,
- ExternalFeedbackReporter* feedback_reporter,
+ DistillerUIHandle* distiller_ui_handle,
mojo::InterfaceRequest<DistillerJavaScriptService> request);
} // namespace dom_distiller

Powered by Google App Engine
This is Rietveld 408576698