components/dom_distiller/content/common/distiller_javascript_service.mojom - Issue 1386043002: Open distiller UI setting through JavaScript

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/dom_distiller/content/common/distiller_javascript_service.mojom

Issue 1386043002: Open distiller UI setting through JavaScript (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add missing file Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/android/java/src/org/chromium/chrome/browser/dom_distiller/DomDistillerUIUtils.java ('K') | « components/dom_distiller/content/browser/dom_distiller_viewer_source.cc ('k') | components/dom_distiller/content/renderer/distiller_native_javascript.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/dom_distiller/content/common/distiller_javascript_service.mojom

diff --git a/components/dom_distiller/content/common/distiller_javascript_service.mojom b/components/dom_distiller/content/common/distiller_javascript_service.mojom

index 3f0f89a6f2f0050659217c9f606a37d15dddd23c..cb97f11ccc11af0a7120c871e8963d33dafaecc8 100644

--- a/components/dom_distiller/content/common/distiller_javascript_service.mojom

+++ b/components/dom_distiller/content/common/distiller_javascript_service.mojom

@@ -17,4 +17,8 @@ interface DistillerJavaScriptService {

// Handle closing the overlay panel that contains Reader Mode; the

// "distiller.close" function.

HandleDistillerClosePanelCall();

+ // Open the Android view containing settings for Reader Mode

+ // (distiller.openSettings).

nyquist 2015/10/14 17:48:22 Nit: This JavaScript function name is different th

mdjones 2015/10/14 20:55:42 Done.

+ HandleDistillerOpenSettingsCall();

};