Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(56)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1385943002: GN: Don't attempt incremental install with sandboxes on some samsung devices (Closed)

Created:
5 years, 2 months ago by agrieve
Modified:
5 years, 2 months ago
Reviewers:
pkotwicz
CC:
chromium-reviews, asanka, benjhayden+dwatch_chromium.org, klundberg+watch_chromium.org, yfriedman+watch_chromium.org, jbudorick+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@device-utils-caching
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

GN: Don't attempt incremental install with isolated processes on some samsung devices My S5 running 5.1.1 has an SELinux policy similar to Android M. BUG=520082 Committed: https://crrev.com/d4eb0d367eb7b3d89d35e494b93863b737597b57 Cr-Commit-Position: refs/heads/master@{#352439}

Patch Set 1 #

Total comments: 4

Patch Set 2 : nits #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -8 lines) Patch
M build/android/incremental_install/installer.py View 1 2 chunks +13 lines, -8 lines 0 comments Download

Depends on Patchset:

Issue 1375043002 Patch 120001

Dependent Patchsets:

Issue 1388863002 Patch 1

Messages

Total messages: 15 (5 generated)
agrieve
On 2015/10/05 18:10:13, agrieve wrote: > mailto:agrieve@chromium.org changed reviewers: > + mailto:pkotwicz@chromium.org ptal
5 years, 2 months ago (2015-10-05 18:10:19 UTC) #2
agrieve
On 2015/10/05 18:10:13, agrieve wrote: > mailto:agrieve@chromium.org changed reviewers: > + mailto:pkotwicz@chromium.org ptal
5 years, 2 months ago (2015-10-05 18:10:21 UTC) #3
pkotwicz
LGTM Can you clean up the CL description. I am not sure what "Those that ...
5 years, 2 months ago (2015-10-05 19:37:46 UTC) #4
agrieve
On 2015/10/05 19:37:46, pkotwicz wrote: > LGTM > > Can you clean up the CL ...
5 years, 2 months ago (2015-10-05 19:46:04 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1385943002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1385943002/1
5 years, 2 months ago (2015-10-05 19:48:00 UTC) #7
pkotwicz
Sorry, forgot to mail the nits https://codereview.chromium.org/1385943002/diff/1/build/android/incremental_install/installer.py File build/android/incremental_install/installer.py (right): https://codereview.chromium.org/1385943002/diff/1/build/android/incremental_install/installer.py#newcode165 build/android/incremental_install/installer.py:165: def check_sdk_version(): Perhaps ...
5 years, 2 months ago (2015-10-05 20:02:35 UTC) #9
agrieve
https://codereview.chromium.org/1385943002/diff/1/build/android/incremental_install/installer.py File build/android/incremental_install/installer.py (right): https://codereview.chromium.org/1385943002/diff/1/build/android/incremental_install/installer.py#newcode165 build/android/incremental_install/installer.py:165: def check_sdk_version(): On 2015/10/05 20:02:34, pkotwicz wrote: > Perhaps ...
5 years, 2 months ago (2015-10-05 20:08:45 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1385943002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1385943002/20001
5 years, 2 months ago (2015-10-05 20:11:29 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 2 months ago (2015-10-05 22:07:10 UTC) #14
commit-bot: I haz the power
5 years, 2 months ago (2015-10-05 22:07:51 UTC) #15
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/d4eb0d367eb7b3d89d35e494b93863b737597b57
Cr-Commit-Position: refs/heads/master@{#352439}

Powered by Google App Engine
This is Rietveld 408576698