GN: Don't attempt incremental install with sandboxes on some samsung devices

build/android/incremental_install/installer.py

 #!/usr/bin/env python
 #
 # Copyright 2015 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """Install *_incremental.apk targets as well as their dependent files."""
 
 import argparse
 import glob
@@ skipping 144 matching lines @@
       with build_utils.TempDir() as temp_dir:
         device_dex_dir = posixpath.join(device_incremental_dir, 'dex')
         # Ensure no two files have the same name.
         transformed_names = _TransformDexPaths(args.dex_files)
         for src_path, dest_name in zip(args.dex_files, transformed_names):
           shutil.copyfile(src_path, os.path.join(temp_dir, dest_name))
         device.PushChangedFiles([(temp_dir, device_dex_dir)],
                                 delete_device_stale=True)
       push_dex_timer.Stop(log=False)
 
   def check_sdk_version():

[pkotwicz, 2015/10/05 20:02:34]

Perhaps rename this to check_selinux() ?

[agrieve, 2015/10/05 20:08:45]

Done.

-    if device.build_version_sdk >= version_codes.MARSHMALLOW:
-      if apk_help.HasIsolatedProcesses():
-        raise Exception('Cannot use perform incremental installs on Android M+ '
-                        'without first disabling isolated processes.\n'
-                        'To do so, use GN arg:\n'
-                        '    disable_incremental_isolated_processes=true')
+    # Samsung started using SELinux before Marshmallow. There may be even more
+    # cases where this is required...
+    has_selinux = (device.build_version_sdk >= version_codes.MARSHMALLOW or
+                   device.GetProp('selinux.policy_version'))
+    if has_selinux and apk_help.HasIsolatedProcesses():
+      raise Exception('Cannot use incremental installs on Android devices that '
+                      'use using SELinux policies without first disabling '

[pkotwicz, 2015/10/05 20:02:34]

Nit: Remove 'using'

[agrieve, 2015/10/05 20:08:45]

Done.

+                      'isolated processes.\n'
+                      'To do so, use GN arg:\n'
+                      '    disable_incremental_isolated_processes=true')
 
   cache_path = '%s/files-cache.json' % device_incremental_dir
   def restore_cache():
     # Delete the cached file so that any exceptions cause the next attempt
     # to re-compute md5s.
     cmd = 'P=%s;cat $P 2>/dev/null && rm $P' % cache_path
     lines = device.RunShellCommand(cmd, check_return=False, large_output=True)
     if lines:
       device.LoadCacheData(lines[0])
     else:
@@ skipping 32 matching lines @@
   logging.info(
       'Took %s seconds (setup=%s, install=%s, libs=%s, dex=%s, finalize=%s)',
       main_timer.GetDelta(), setup_timer.GetDelta(), install_timer.GetDelta(),
       push_native_timer.GetDelta(), push_dex_timer.GetDelta(),
       finalize_timer.GetDelta())
 
 
 if __name__ == '__main__':
   sys.exit(main())