gpu/command_buffer/service/in_process_command_buffer.h - Issue 1385883002: Leave CreateStreamTexture route id out of the GL interface.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: gpu/command_buffer/service/in_process_command_buffer.h

Issue 1385883002: Leave CreateStreamTexture route id out of the GL interface. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/renderer/render_frame_impl.cc ('K') | « gpu/command_buffer/cmd_buffer_functions.txt ('k') | gpu/command_buffer/tests/gl_manager.h » ('j') | gpu/command_buffer/tests/gl_manager.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: gpu/command_buffer/service/in_process_command_buffer.h

diff --git a/gpu/command_buffer/service/in_process_command_buffer.h b/gpu/command_buffer/service/in_process_command_buffer.h

index dc33c35dda8099be53029d0b3173d04cb07ac2c0..7089d5d51e21fe966a401620724e2512d11a4587 100644

--- a/gpu/command_buffer/service/in_process_command_buffer.h

+++ b/gpu/command_buffer/service/in_process_command_buffer.h

@@ -125,7 +125,7 @@ class GPU_EXPORT InProcessCommandBuffer : public CommandBuffer,

const base::Closure& callback) override;

void SignalQuery(uint32 query_id, const base::Closure& callback) override;

void SetSurfaceVisible(bool visible) override;

- uint32 CreateStreamTexture(uint32 texture_id) override;

+ uint32 CreateStreamTexture(uint32 texture_id);

no sievers 2015/10/27 16:58:56 nit: move to non-virtual functions

sivag 2015/11/05 09:42:50 Done.

void SetLock(base::Lock*) override;

bool IsGpuChannelLost() override;

CommandBufferNamespace GetNamespaceID() const override;

« content/renderer/render_frame_impl.cc ('K') | « gpu/command_buffer/cmd_buffer_functions.txt ('k') | gpu/command_buffer/tests/gl_manager.h » ('j') | gpu/command_buffer/tests/gl_manager.h » ('J')