content/renderer/render_frame_impl.cc - Issue 1385883002: Leave CreateStreamTexture route id out of the GL interface.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/render_frame_impl.cc

Issue 1385883002: Leave CreateStreamTexture route id out of the GL interface. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/common/gpu/client/command_buffer_proxy_impl.h ('K') | « content/renderer/media/android/stream_texture_factory_synchronous_impl.cc ('k') | gpu/GLES2/gl2chromium_autogen.h » ('j') | gpu/command_buffer/service/in_process_command_buffer.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/renderer/render_frame_impl.cc

diff --git a/content/renderer/render_frame_impl.cc b/content/renderer/render_frame_impl.cc

index 255684a5683e0c29ca08255f2da079451abeecf2..9cde890f99172155973ca3183df122a3b64cc5d5 100644

--- a/content/renderer/render_frame_impl.cc

+++ b/content/renderer/render_frame_impl.cc

@@ -5174,8 +5174,10 @@ WebMediaPlayer* RenderFrameImpl::CreateAndroidWebMediaPlayer(

return NULL;

}

- scoped_refptr<cc_blink::ContextProviderWebContext> context_provider =

- RenderThreadImpl::current()->SharedMainThreadContextProvider();

+ ContextProviderCommandBuffer* ptr = reinterpret_cast<

no sievers 2015/10/27 16:58:56 this cast we still want to avoid

sivag 2015/11/05 09:42:50 Done.

+ ContextProviderCommandBuffer*>(

+ RenderThreadImpl::current()->SharedMainThreadContextProvider().get());

+ scoped_refptr<ContextProviderCommandBuffer> context_provider(ptr);

if (!context_provider.get()) {

LOG(ERROR) << "Failed to get context3d for media player";