Do not allow federated logins saved from Android apps to be affiliated matches.

Do not allow federated logins saved from Android apps to be affiliated matches.

BUG=539833
R=vabr@chromium.org,mkwst@chromium.org

Committed: https://crrev.com/4e13fe538e97fefaa9044b70e152a3c5c808fd36
Cr-Commit-Position: refs/heads/master@{#352589}

[engedy, 2015-10-06 11:54:10]

Mike, Vaclav, could you please review?

Admittedly, this is a heavy-handed solution.  However, the Credential Manager
API, which is the sole consumer of such logins, is using a completely different
code path for obtaining affiliated logins anyway, so it does not matter at all,
at least for filling.

For updating existing credentials, it's a somewhat different story, as the
Credential Manager relies on PasswordFormManager (and consequently on
PasswordStore::GetLogins()) to update the credentials in the database.  The
worst thing that can happen is that it will end up creating a new login.  Given
that this is the behavior anyway for non-federated logins, I think this should
be fine.

In any case, I will file a bug and investigate what's going on there.

[Mike West, 2015-10-06 11:59:48]

It is heavy-handed, but it also seems correct. Since we're not using this API in
the only place in the code that needs to return federted affiliated credentials,
I don't think any undesirable behavior change should result.

I'd suggest adding a comment to PasswordStore::GetLogins to note the exclusion,
so that the callers' expectations are set correctly. Otherwise LGTM.

[vabr (Chromium), 2015-10-06 12:14:40]

LGTM, seems sane.
+1 to Mike's comment about adding a comment. :)

Cheers,
Vaclav

[engedy, 2015-10-06 12:15:02]

Done, added comment.

[engedy, 2015-10-06 12:15:06]

The CQ bit was checked by engedy@chromium.org

[engedy, 2015-10-06 12:15:06]

The patchset sent to the CQ was uploaded after l-g-t-m from mkwst@chromium.org
Link to the patchset: https://codereview.chromium.org/1385563007/#ps20001
(title: "Added comment.")

[commit-bot: I haz the power, 2015-10-06 12:15:21]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1385563007/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1385563007/20001

[commit-bot: I haz the power, 2015-10-06 13:03:16]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-10-06 13:04:13]

Patchset 2 (id:??) landed as
https://crrev.com/4e13fe538e97fefaa9044b70e152a3c5c808fd36
Cr-Commit-Position: refs/heads/master@{#352589}