components/password_manager/core/browser/password_store_unittest.cc - Issue 1385563007: Do not allow federated logins saved from Android apps to be affiliated matches.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/password_manager/core/browser/password_store_unittest.cc

Issue 1385563007: Do not allow federated logins saved from Android apps to be affiliated matches. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Added comment. Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: components/password_manager/core/browser/password_store_unittest.cc

diff --git a/components/password_manager/core/browser/password_store_unittest.cc b/components/password_manager/core/browser/password_store_unittest.cc

index ba7c217af1966fcd592d8eb41fac364ee4de9301..d94445d95416577534e3b6d7fcdfbbf1efb8b733 100644

--- a/components/password_manager/core/browser/password_store_unittest.cc

+++ b/components/password_manager/core/browser/password_store_unittest.cc

@@ -508,6 +508,13 @@ TEST_F(PasswordStoreTest, GetLoginsWithAffiliations) {

"", "", L"", L"", L"",

L"username_value_4",

L"", true, true, 1},

+ // Federated credential for this second Android application; this should

+ // not be returned.

+ {PasswordForm::SCHEME_HTML,

+ kTestAndroidRealm2,

+ "", "", L"", L"", L"",

+ L"username_value_4b",

+ kTestingFederatedLoginMarker, true, true, 1},

// Credential for an unrelated Android application.

{PasswordForm::SCHEME_HTML,

kTestUnrelatedAndroidRealm,

« no previous file with comments | « components/password_manager/core/browser/password_store.cc ('k') | no next file » | no next file with comments »