Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(939)

Issue 1385323003: Revert of Enable testing of WebRTC IP Permission Finch (Closed)

Created:
5 years, 2 months ago by guoweis_left_chromium
Modified:
5 years, 2 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Enable testing of WebRTC IP Permission Finch (patchset #1 id:1 of https://codereview.chromium.org/1380323005/ ) Reason for revert: Hmm, this still causes the failure. When I tested it, I could repro it but not anymore after the checkin I mentioned. Revert it again to do more investigation. Original issue's description: > Reland of Enable testing of WebRTC IP Permission Finch (patchset #2 id:40002 of https://codereview.chromium.org/1388913002/ ) > > Reason for revert: > The original check in broke test and has been fixed by https://codereview.chromium.org/1381703006 > > Original issue's description: > > Revert of Enable testing of WebRTC IP Permission Finch (patchset #1 id:1 of https://codereview.chromium.org/1380893005/ ) > > > > Reason for revert: > > Speculative revert since we see failing tests in the WebRTC waterfall related to ICE. > > > > See > > > > https://build.chromium.org/p/chromium.webrtc/builders/Win7%20Tester/builds/21950 > > https://build.chromium.org/p/chromium.webrtc/builders/Mac%20Tester/builds/43969 > > > > Original issue's description: > > > Enable testing of WebRTC IP Permission Finch > > > > > > BUG=538815 > > > > > > Committed: https://crrev.com/efce5aa89bc5ac68f96184e44c4bb4b8c3a985e8 > > > Cr-Commit-Position: refs/heads/master@{#352420} > > > > TBR=brettw@chromium.org,rkaplow@chromium.org,guoweis@chromium.org > > NOPRESUBMIT=true > > NOTREECHECKS=true > > NOTRY=true > > BUG=538815 > > > > Committed: https://crrev.com/565e0d0173c5fb39441b773052de9f391060258b > > Cr-Commit-Position: refs/heads/master@{#352570} > > TBR=brettw@chromium.org,rkaplow@chromium.org,henrika@chromium.org > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=538815 > > Committed: https://crrev.com/336786c5beb64348189f2f6cf9a5b2de14e37965 > Cr-Commit-Position: refs/heads/master@{#352695} TBR=brettw@chromium.org,rkaplow@chromium.org,henrika@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=538815 Committed: https://chromium.googlesource.com/chromium/src/+/df942bc2ba62c6064a1f3f0a1c74076ea49a24be

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -25 lines) Patch
M testing/variations/fieldtrial_testing_config_android.json View 1 chunk +0 lines, -5 lines 0 comments Download
M testing/variations/fieldtrial_testing_config_chromeos.json View 1 chunk +0 lines, -5 lines 0 comments Download
M testing/variations/fieldtrial_testing_config_linux.json View 1 chunk +0 lines, -5 lines 0 comments Download
M testing/variations/fieldtrial_testing_config_mac.json View 1 chunk +0 lines, -5 lines 0 comments Download
M testing/variations/fieldtrial_testing_config_win.json View 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
guoweis_left_chromium
Created Revert of Enable testing of WebRTC IP Permission Finch
5 years, 2 months ago (2015-10-06 23:04:51 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1385323003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1385323003/1
5 years, 2 months ago (2015-10-06 23:10:01 UTC) #2
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. Only full committers are accepted. Even if an ...
5 years, 2 months ago (2015-10-06 23:10:03 UTC) #4
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/df942bc2ba62c6064a1f3f0a1c74076ea49a24be Cr-Commit-Position: refs/heads/master@{#352709}
5 years, 2 months ago (2015-10-06 23:28:15 UTC) #5
Niklas Enbom
5 years, 2 months ago (2015-10-06 23:28:36 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
df942bc2ba62c6064a1f3f0a1c74076ea49a24be (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698