Issue 13853009: Reverting base class for CachedSVGDocumentReference to avoid platform layering violations

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 13853009: Reverting base class for CachedSVGDocumentReference to avoid platform layering violations

Created:
7 years, 8 months ago by achicu

Modified:
7 years, 8 months ago

Reviewers:
Stephen White

CC:
blink-reviews, jamesr, Stephen White

Base URL:
https://chromium.googlesource.com/chromium/blink@master

Visibility:
Public.

More Reviews

Description

Reverting base class for CachedSVGDocumentReference to avoid platform layering violations Original commit that introduced the issue was: https://bugs.webkit.org/show_bug.cgi?id=102967 BUG=

Patch Set 1 #

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+14 lines, -16 lines)			Patch
M	Source/WebCore/css/StyleResolver.cpp	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	Source/WebCore/loader/cache/CachedSVGDocumentReference.h	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	Source/WebCore/platform/graphics/filters/FilterOperation.h	View	3 chunks	+8 lines, -11 lines	0 comments	Download
M	Source/WebCore/rendering/FilterEffectRenderer.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/WebCore/rendering/RenderLayerFilterInfo.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages

Stephen White

7 years, 8 months ago (2013-04-22 20:30:47 UTC) #1

LGTM.

FYI, unlike Bugzilla, Rietveld does not send an email when you add cc's or
reviewers, so be sure to send a "please take a look" message once you've got
them in place.

Expand Messages | Collapse Messages