Source/WebCore/rendering/FilterEffectRenderer.cpp - Issue 13853009: Reverting base class for CachedSVGDocumentReference to avoid platform layering violations

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/WebCore/rendering/FilterEffectRenderer.cpp

Issue 13853009: Reverting base class for CachedSVGDocumentReference to avoid platform layering violations Base URL: https://chromium.googlesource.com/chromium/blink@master

Patch Set: Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « Source/WebCore/platform/graphics/filters/FilterOperation.h ('k') | Source/WebCore/rendering/RenderLayerFilterInfo.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/WebCore/rendering/FilterEffectRenderer.cpp

diff --git a/Source/WebCore/rendering/FilterEffectRenderer.cpp b/Source/WebCore/rendering/FilterEffectRenderer.cpp

index c23fa5fbc22e68dbaca7bc3e50c16f640d397c8a..78cb776e1c400365202ff241f350ef56540af299 100644

--- a/Source/WebCore/rendering/FilterEffectRenderer.cpp

+++ b/Source/WebCore/rendering/FilterEffectRenderer.cpp

@@ -128,7 +128,7 @@ PassRefPtr<FilterEffect> FilterEffectRenderer::buildReferenceFilter(RenderObject

Document* document = renderer->document();

ASSERT(document);

- CachedSVGDocumentReference* cachedSVGDocumentReference = filterOperation->cachedSVGDocumentReference();

+ CachedSVGDocumentReference* cachedSVGDocumentReference = static_cast<CachedSVGDocumentReference*>(filterOperation->data());

CachedSVGDocument* cachedSVGDocument = cachedSVGDocumentReference ? cachedSVGDocumentReference->document() : 0;

// If we have an SVG document, this is an external reference. Otherwise

« no previous file with comments | « Source/WebCore/platform/graphics/filters/FilterOperation.h ('k') | Source/WebCore/rendering/RenderLayerFilterInfo.cpp » ('j') | no next file with comments »