Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(691)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 138523003: Removed unnecessary parameter from didActivateCompositor() (Closed)

Created:
6 years, 11 months ago by Sunil Ratnu
Modified:
6 years, 8 months ago
Reviewers:
jam, abarth-chromium
CC:
blink-reviews, jamesr, dglazkov+blink, abarth-chromium
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Removed unnecessary parameter from didActivateCompositor() The parameter to didActivateCompositor() is meaningless. Hence, removed it. The other chromium side changes are here https://codereview.chromium.org/137893025/ BUG=None Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=170535

Patch Set 1 #

Patch Set 2 : Removing two more occurrences of parameter in didActivateCompositor method in WebPopupMenuImpl.cpp #

Patch Set 3 : Removing unnecessary argument in another file: Source/web/WebPagePopupImpl.cpp #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -7 lines) Patch
M Source/web/WebPagePopupImpl.cpp View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M Source/web/WebPopupMenuImpl.cpp View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M Source/web/WebViewImpl.cpp View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M public/web/WebWidgetClient.h View 1 2 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 19 (0 generated)
Sunil Ratnu
Please have a look.
6 years, 11 months ago (2014-01-19 08:04:42 UTC) #1
abarth-chromium
lgtm
6 years, 11 months ago (2014-01-19 16:21:27 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sunil.ratnu@samsung.com/138523003/1
6 years, 11 months ago (2014-01-20 05:49:39 UTC) #3
commit-bot: I haz the power
Retried try job too often on linux_blink_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_blink_rel&number=18173
6 years, 11 months ago (2014-01-20 06:18:28 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sunil.ratnu@samsung.com/138523003/1
6 years, 11 months ago (2014-01-20 07:02:32 UTC) #5
commit-bot: I haz the power
Retried try job too often on linux_blink_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_blink_rel&number=18186
6 years, 11 months ago (2014-01-20 07:29:09 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sunil.ratnu@samsung.com/138523003/1
6 years, 11 months ago (2014-01-20 09:18:57 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sunil.ratnu@samsung.com/138523003/1
6 years, 11 months ago (2014-01-20 14:08:49 UTC) #8
Sunil Ratnu
The CQ bit was checked by sunil.ratnu@samsung.com
6 years, 9 months ago (2014-03-13 10:16:23 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sunil.ratnu@samsung.com/138523003/400001
6 years, 9 months ago (2014-03-13 10:16:25 UTC) #10
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-13 10:45:50 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on linux_blink_rel
6 years, 9 months ago (2014-03-13 10:45:50 UTC) #12
Sunil Ratnu
The CQ bit was checked by sunil.ratnu@samsung.com
6 years, 9 months ago (2014-03-13 17:16:56 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sunil.ratnu@samsung.com/138523003/400001
6 years, 9 months ago (2014-03-13 17:17:02 UTC) #14
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-13 17:17:37 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on win_blink_rel
6 years, 9 months ago (2014-03-13 17:17:38 UTC) #16
Sunil Ratnu
The CQ bit was checked by sunil.ratnu@samsung.com
6 years, 8 months ago (2014-04-01 06:26:11 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sunil.ratnu@samsung.com/138523003/400001
6 years, 8 months ago (2014-04-01 06:26:12 UTC) #18
commit-bot: I haz the power
6 years, 8 months ago (2014-04-01 09:06:39 UTC) #19
Message was sent while issue was closed. 
Change committed as 170535

Powered by Google App Engine
This is Rietveld 408576698