Source/web/WebPagePopupImpl.cpp - Issue 138523003: Removed unnecessary parameter from didActivateCompositor()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/web/WebPagePopupImpl.cpp

Issue 138523003: Removed unnecessary parameter from didActivateCompositor() (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Removing unnecessary argument in another file: Source/web/WebPagePopupImpl.cpp Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/web/WebPagePopupImpl.cpp

diff --git a/Source/web/WebPagePopupImpl.cpp b/Source/web/WebPagePopupImpl.cpp

index 2a20ed18409e8d8d0bbcf23b2fd8e4d82141eea5..010344573f7e516f710bf7d0f402c2ed91a4ac13 100644

--- a/Source/web/WebPagePopupImpl.cpp

+++ b/Source/web/WebPagePopupImpl.cpp

@@ -264,7 +264,7 @@ void WebPagePopupImpl::setIsAcceleratedCompositingActive(bool enter)

m_widgetClient->didDeactivateCompositor();

} else if (m_layerTreeView) {

m_isAcceleratedCompositingActive = true;

- m_widgetClient->didActivateCompositor(0);

+ m_widgetClient->didActivateCompositor();

} else {

TRACE_EVENT0("webkit", "WebPagePopupImpl::setIsAcceleratedCompositingActive(true)");

@@ -272,7 +272,7 @@ void WebPagePopupImpl::setIsAcceleratedCompositingActive(bool enter)

m_layerTreeView = m_widgetClient->layerTreeView();

if (m_layerTreeView) {

m_layerTreeView->setVisible(true);

- m_widgetClient->didActivateCompositor(0);

+ m_widgetClient->didActivateCompositor();

m_isAcceleratedCompositingActive = true;

m_layerTreeView->setDeviceScaleFactor(m_widgetClient->deviceScaleFactor());

} else {

« no previous file with comments | « no previous file | Source/web/WebPopupMenuImpl.cpp » ('j') | no next file with comments »